Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Revert "feat: Add submission limits for storage mode form submissions (#1097) #1265

Merged
merged 1 commit into from
Mar 3, 2021

Conversation

liangyuanruo
Copy link
Contributor

@liangyuanruo liangyuanruo commented Mar 2, 2021

To address the following changes before release:

  • changes from reviewing staging
  • tooltip: Form will automatically deactivate when the set response limit is reached. Enable reCaptcha to prevent spam submissions from triggering this limit.
  • “Maximum number of responses allowed”
  • change error message below the input field from blue to red
  • Schema validation that only allows positive submission limits values

@liangyuanruo
Copy link
Contributor Author

@mantariksh @tshuli @karrui @frankchn this shouldn't be released due to changes yet to be addressed

@liangyuanruo liangyuanruo merged commit a9caa45 into develop Mar 3, 2021
@liangyuanruo liangyuanruo deleted the chore/revert-sub-cap branch March 3, 2021 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants