Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: remove unused await-to-js #1345

Merged
merged 2 commits into from
Mar 10, 2021
Merged

build: remove unused await-to-js #1345

merged 2 commits into from
Mar 10, 2021

Conversation

liangyuanruo
Copy link
Contributor

Problem

Dependency is unused.

@liangyuanruo liangyuanruo added the P2 planned for next 1-2 months label Mar 10, 2021
karrui
karrui approved these changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@karrui karrui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah... our first foray into error handling... good times

@liangyuanruo liangyuanruo merged commit aa0fea0 into develop Mar 10, 2021
@liangyuanruo liangyuanruo deleted the build/await-to-js branch March 10, 2021 22:30
@mantariksh mantariksh mentioned this pull request Mar 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karrui karrui karrui approved these changes

Assignees
No one assigned
Labels
P2 planned for next 1-2 months
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liangyuanruo @karrui