refactor: Migrate 3 more filters to handleEncryptedSubmission #1420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankchn
force-pushed
the
frank-controllers-2
branch
from
8bcad30
to
235350c
Compare
liangyuanruo
suggested changes
Mar 22, 2021
…cated, and verifyMyInfoVals to handleEncryptedSubmission
frankchn
force-pushed
the
frank-controllers-2
branch
from
6fd7f66
to
d006479
Compare
|
@liangyuanruo Tests are fixed, PTAL again :) |
src/app/modules/submission/encrypt-submission/encrypt-submission.controller.ts
Outdated
Show resolved
Hide resolved
src/app/modules/submission/encrypt-submission/encrypt-submission.controller.ts
Outdated
Show resolved
Hide resolved
src/app/modules/submission/encrypt-submission/encrypt-submission.controller.ts
Show resolved
Hide resolved
liangyuanruo
approved these changes
Mar 26, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Part of the set of pull requests that addresses #149
Solution
Migrate
validateAndProcessEncryptSubmission,isSpcpAuthenticated, andverifyMyInfoValstohandleEncryptedSubmission.