Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Release v5.5.1 #1603

Merged
merged 2 commits into from
Apr 10, 2021
Merged

build: Release v5.5.1 #1603

merged 2 commits into from
Apr 10, 2021

Conversation

karrui
Copy link
Contributor

@karrui karrui commented Apr 9, 2021 •
edited
Loading

Release v5.5.1

Features

orbitalsqwib and others added 2 commits April 9, 2021 09:21
@orbitalsqwib @karrui
refactor(corppass-ui): make ui changes for corppass (#1533)
d480dfe 
* refactor(corppass-ui): make ui changes for corppass

- updated copy for ui
- updated minimum necessary user-facing mentions of singpass and corppass to use new casing
- made necessary frontend changes for corporate singpass button
- added tooltip beside corppass option in settings > enable authentication
- updated e2e tests for new changes

* fix(start-page): increase corp login hor. padding
@karrui
chore: bump version to v5.5.1
aca5c20
@mantariksh
Copy link
Contributor

mantariksh commented Apr 9, 2021 •
edited by karrui
Loading

Tests

Login button for CorpPass-authenticated forms

  • Should now display the text "Login with Singpass (Corporate)"
  • Should resize automatically based on viewport width (e.g: one line on desktop, two or more lines on mobile)
  • Text below button should now read Corporate entity login is required for this form. Your Singpass ID and corporate Entity ID will be included with your form submission."

Login button for SingPass-authenticated forms

  • Should now display the text "Login with Singpass"

Post-CorpPass-authentication redirect page (Both Admin Preview and normal user views)

  • Text beneath log out button should read "Logged in as corporate user"

Form > Settings > Authentication

  • Check that tooltip appears next to "Corppass" and displays text "Corppass no longer has its own login page, and now uses Singpass to authenticate corporate users. You will still need a separate Corppass e-service ID." when moused-over.

@mantariksh mantariksh changed the base branch from develop to release April 9, 2021 03:26
@karrui karrui merged commit 8a5eef8 into release Apr 10, 2021
@karrui karrui deleted the release-v5.5.1 branch August 17, 2021 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mantariksh mantariksh mantariksh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karrui @mantariksh @orbitalsqwib