build: hotfix release v5.6.1 #1634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bug prevented users from counting same day responses
liangyuanruo
approved these changes
Apr 13, 2021
mantariksh
approved these changes
Apr 13, 2021
seaerchin
added a commit
that referenced
this pull request
Apr 14, 2021
…nt and submissions/download as start date can be equal to end date, the hotfix in #1634 was ported over. additionally, an extra unit test for /submissions/download was added to ensure that the same issue does not plague it
seaerchin
added a commit
that referenced
this pull request
Apr 14, 2021
* style(admin-forms/feedback): fixed misspelling of admin * refactor(admin-form/controller): combined validator into handleCountFormSubmission * refactor(admin-forms/submissions): duplicates over submissions over to new routes * refactor(submissions/client/factory): removed FE callsite * fix(admin-forms/submission): adds joi/date to base joi * test(admin-forms/submissions): adds test from old route * fix(submissions/client/factory): fixed endpoints for adminform * refactor(encrypt-submission): combines validation together with handler * test(encrypt-submission): fixes controller tests due to atomic export for validator + handler * test(admin-forms/submissoins): ports over tests for submissions/download * refactor(submissions/client/factory): changed frontend to call new backend api * chore(admin-forms/submissions): renamed file from submission to submissions * style(submissions/client/factory): combined api and admin form prefix into one * fix(admin-form/encrypt-submission): fixed date validation to be min instead of greater * test(admin-forms): added tests for date validation to submissions/count and submissions/download as start date can be equal to end date, the hotfix in #1634 was ported over. additionally, an extra unit test for /submissions/download was added to ensure that the same issue does not plague it * style(admin-forms/submissions): changed submission to be submissionS * docs(admin-forms/submissions): fixed comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release v5.6.1
This release fixes a bug where
/adminform/submissions/downloadand/adminform/submissions/countreturned a HTTP status400whenquery.startDateandquery.endDatevalues were equal.Fixes