refactor(preview-api): duplicate adminform preview endpoints for /api/v3 #1643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/v3i - duplicate and update adminform form related endpoints - duplicate integration tests for new endpoint - update v3 router to use new endpoints - update frontend api calls to use new endpoints
…i/v3 - duplicate and update adminform preview related endpoints - duplicate integration tests for new endpoint - update v3 router to use new endpoints - update frontend api calls to use new endpoints
orbitalsqwib
force-pushed
the
ref/preview-api
branch
from
2b0b390
to
3f4aa16
Compare
|
Rebased this onto ref/admin-form-api tracked by #1635 |
2 tasks
mantariksh
reviewed
Apr 20, 2021
src/app/routes/api/v3/admin/forms/admin-forms.preview.routes.ts
Outdated
Show resolved
Hide resolved
src/app/routes/api/v3/admin/forms/admin-forms.preview.routes.ts
Outdated
Show resolved
Hide resolved
- shift validators into admin-form controller - update handler methods to include middleware as request handler array - update controller integration tests - update old routes to use new handler - update new routes to use new handler
|
to fix merge conflicts before approval |
|
@orbitalsqwib gotta fix merge conflicts again I think |
mantariksh
approved these changes
Apr 21, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Updates current adminform preview-related endpoints to their /api rooted endpoints to follow a RESTful hierarchy.
Closes #1510
Solution
Features:
Tests