refactor: use shared DateSelectedValidation enum instead of DATE_VALIDATION_OPTIONS #1724
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
An enum called
DateSelectedValidation
was introduced during a typescript migration task #749, but the frontend codebase has not been updated to make use of this enum.Closes #777
Solution
Remove the naming conflict between
DateValidationOptions
andDATE_VALIDATION_OPTIONS
. The former is actually a list of options and the latter is the enum. The former is now called DateValidationOptionList.Edit usages of the enum from lower-case to title-case to match the new enum. i.e.
DateValidationOptions.custom
toDateValidationOptions.Custom
Reviewers
@tshuli appreciate if you could take a quick look to see if these changes are indeed what you had intended.