-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api-refactor): implement specific reorder field api #1726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
used to improve typings from types that may extend from arrays even if they are not primitive arrays
frontend seems to need it too :(
mantariksh
approved these changes
Apr 26, 2021
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration tests will be added to a separate PR to prevent PR size from becoming too big
This PR cannot be rolled back after release due to the invocation of the new endpoint on the client side.
Problem
This PR adds a specific endpoint to reorder form fields in the form, and updates the frontend client to use that endpoint when reordering fields. There is also a feature to undo the field reordering if the reorder network request fails for one reason or another.
Closes #1482
Solution
Backend Features:
Client Features
Improvements:
Bug Fixes:
Tests
Manual tests