Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: release v5.9.0 #1783

Merged
merged 26 commits into from
May 5, 2021
Merged

build: release v5.9.0 #1783

merged 26 commits into from
May 5, 2021

Conversation

yong-jie
Copy link
Member

@yong-jie yong-jie commented May 4, 2021 •
edited
Loading

Release v5.9.0

Features

  • feat(api-refactor): implement specific delete form field api #1731
  • refactor(api): collapse /validate into single endpoint #1725

Bug fixes

  • fix: allow commas in email confirmation sender #1782
  • fix: trigger digest cycle for delete logic #1787

Misc

  • test(integration): integration tests for /validate endpoint #1740

Dependency upgrades

  • fix(deps): bump @babel/runtime from 7.13.17 to 7.14.0 #1771
  • fix(deps): bump @sentry/browser from 6.3.1 to 6.3.3 #1754
  • fix(deps): bump @sentry/browser from 6.3.3 to 6.3.4 #1764
  • fix(deps): bump @sentry/browser from 6.3.4 to 6.3.5 #1773
  • fix(deps): bump @sentry/integrations from 6.3.1 to 6.3.3 #1755
  • fix(deps): bump @sentry/integrations from 6.3.3 to 6.3.4 #1765
  • fix(deps): bump @sentry/integrations from 6.3.4 to 6.3.5 #1774
  • fix(deps): bump aws-sdk from 2.893.0 to 2.894.0 #1756
  • fix(deps): bump aws-sdk from 2.894.0 to 2.895.0 #1766
  • fix(deps): bump aws-sdk from 2.895.0 to 2.897.0 #1776
  • fix(deps): bump fp-ts from 2.10.4 to 2.10.5 #1781
  • fix(deps): bump helmet from 4.5.0 to 4.6.0 #1770
  • fix(deps): bump nodemailer from 6.5.0 to 6.6.0 #1767

Dev-dependencies

  • chore(deps-dev): bump @babel/core from 7.13.16 to 7.14.0 #1772
  • chore(deps-dev): bump @babel/preset-env from 7.13.15 to 7.14.0 #1769
  • chore(deps-dev): bump @types/node from 14.14.41 to 14.14.43 #1757
  • chore(deps-dev): bump core-js from 3.11.0 to 3.11.1 #1758
  • chore(deps-dev): bump core-js from 3.11.1 to 3.11.2 #1780
  • chore(deps-dev): bump stylelint from 13.13.0 to 13.13.1 #1775

karrui and others added 24 commits April 28, 2021 16:40
@karrui
Merge pull request #1751 from opengovsg/release-v5.8.0
24be889 
chore: merge v5.8.0 into develop
@dependabot
fix(deps): bump @sentry/integrations from 6.3.1 to 6.3.3 (#1755)
a2879ad 
Bumps [@sentry/integrations](https://github.com/getsentry/sentry-javascript) from 6.3.1 to 6.3.3.
- [Release notes](https://github.com/getsentry/sentry-javascript/releases)
- [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md)
- [Commits](getsentry/sentry-javascript@6.3.1...6.3.3)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
fix(deps): bump aws-sdk from 2.893.0 to 2.894.0 (#1756)
0169b03 
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.893.0 to 2.894.0.
- [Release notes](https://github.com/aws/aws-sdk-js/releases)
- [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md)
- [Commits](aws/aws-sdk-js@v2.893.0...v2.894.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump @types/node from 14.14.41 to 14.14.43 (#1757)
de51e36 
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 14.14.41 to 14.14.43.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump core-js from 3.11.0 to 3.11.1 (#1758)
cfa9784 
Bumps [core-js](https://github.com/zloirock/core-js/tree/HEAD/packages/core-js) from 3.11.0 to 3.11.1.
- [Release notes](https://github.com/zloirock/core-js/releases)
- [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md)
- [Commits](https://github.com/zloirock/core-js/commits/v3.11.1/packages/core-js)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@seaerchin
refactor(api): collapse /validate into single endpoint (#1725)
ec74b82 
* docs(myinfo/spcp): added deprecation notice to old routes

* feat(public-form/controller): added new method to validate a form's eservice id

* refactor(auth): adds new validate dto type in auth and updated callsites

* feat(public-forms/auth/routes): adds new route for validation

* refactor(publicformauthservice): added validate method

* chore(myinfo/spcp): removed unused frontend services

* docs(public-form/controller): add docs for controller method

* refactor(public-form/utils): adds new method for mapping validation errors to http errors

* refactor(public-form/controllre): refactored to account for when there is no authtype

* test(public-form/controller): adds unit tests for controller

* test(publicformauthservice/test): deleted tests in myinfo service and added to publicformauthservice

* docs(public-forms/auth/routes): updated docs for route

* refactor(public-form/utils): merged mapValidateEsrvcIdError into mapFormAuthError

* test(publicformauthservice/test): removed redundant test

* style(active-form-modal.client.controller): removed redundant handling for sp vs myinfo

* refactor(public-form/utils): changed app errors to http error mappings to be identical to old

* fix(public-form/controller): removes CP case

see #1725 for details but htis is because formSG is pushing for a validation endpoint in and of
itself and hence, will not use html parsing ot justify if the esrvcId is valid

* Revert "fix(public-form/controller): removes CP case"

This reverts commit f57f7f6.

* fix(public-form/controller): removes CP validation of eservice Id; updated tests

* chore(public-form/utils): updates meta action for mapFormAuthError
@dependabot
fix(deps): bump @sentry/browser from 6.3.1 to 6.3.3 (#1754)
b618e23 
Bumps [@sentry/browser](https://github.com/getsentry/sentry-javascript) from 6.3.1 to 6.3.3.
- [Release notes](https://github.com/getsentry/sentry-javascript/releases)
- [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md)
- [Commits](getsentry/sentry-javascript@6.3.1...6.3.3)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@karrui @mantariksh
feat(api-refactor): implement specific delete form field api (#1731)
41eb98b 
* feat(FormModel): add deleteFormFieldById static method

* feat(AdminFormSvc): add deleteFormField service fn

* feat(AdminFormCtl): add handleDeleteFormField controller handler fn

* feat(AdminFormsRoutes): add route for deleting form field

* feat(client): add AdminFormService.deleteSingleFormField fn

* feat(client): add and use new delete field switch case handling

* test(FormModel): add unit tests for deleteFormFieldById static method

* test(AdminFormSvc): add unit tests for deleteFormField

* test(AdminFormCtl): add unit tests for handleDeleteFormField

* fix: correct logged action

Co-authored-by: Antariksh Mahajan <antarikshmahajan@gmail.com>

Co-authored-by: Antariksh Mahajan <antarikshmahajan@gmail.com>
@seaerchin
test(integration): integration tests for /validate endpoint (#1740)
e5a1e8b 
* test(public-froms/auth/routes/test): adds integration tests for /validate

* test(public-forms/auth/routes): updated tests to account for app error to http error changing

* test(public-forms/auth/routes/test): adds test to ensure authType.CP has no validation
@dependabot
fix(deps): bump @sentry/browser from 6.3.3 to 6.3.4 (#1764)
d75f26e 
Bumps [@sentry/browser](https://github.com/getsentry/sentry-javascript) from 6.3.3 to 6.3.4.
- [Release notes](https://github.com/getsentry/sentry-javascript/releases)
- [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md)
- [Commits](getsentry/sentry-javascript@6.3.3...6.3.4)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
fix(deps): bump aws-sdk from 2.894.0 to 2.895.0 (#1766)
4601dc3 
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.894.0 to 2.895.0.
- [Release notes](https://github.com/aws/aws-sdk-js/releases)
- [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md)
- [Commits](aws/aws-sdk-js@v2.894.0...v2.895.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
fix(deps): bump nodemailer from 6.5.0 to 6.6.0 (#1767)
f97661b 
Bumps [nodemailer](https://github.com/nodemailer/nodemailer) from 6.5.0 to 6.6.0.
- [Release notes](https://github.com/nodemailer/nodemailer/releases)
- [Changelog](https://github.com/nodemailer/nodemailer/blob/master/CHANGELOG.md)
- [Commits](nodemailer/nodemailer@v6.5.0...v6.6.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
fix(deps): bump @sentry/integrations from 6.3.3 to 6.3.4 (#1765)
61073de 
Bumps [@sentry/integrations](https://github.com/getsentry/sentry-javascript) from 6.3.3 to 6.3.4.
- [Release notes](https://github.com/getsentry/sentry-javascript/releases)
- [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md)
- [Commits](getsentry/sentry-javascript@6.3.3...6.3.4)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump @babel/preset-env from 7.13.15 to 7.14.0 (#1769)
1335a1b 
Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.13.15 to 7.14.0.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.14.0/packages/babel-preset-env)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
fix(deps): bump helmet from 4.5.0 to 4.6.0 (#1770)
e6545cd 
Bumps [helmet](https://github.com/helmetjs/helmet) from 4.5.0 to 4.6.0.
- [Release notes](https://github.com/helmetjs/helmet/releases)
- [Changelog](https://github.com/helmetjs/helmet/blob/main/CHANGELOG.md)
- [Commits](helmetjs/helmet@v4.5.0...v4.6.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
fix(deps): bump @babel/runtime from 7.13.17 to 7.14.0 (#1771)
ebdf69b 
Bumps [@babel/runtime](https://github.com/babel/babel/tree/HEAD/packages/babel-runtime) from 7.13.17 to 7.14.0.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.14.0/packages/babel-runtime)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
fix(deps): bump @sentry/browser from 6.3.4 to 6.3.5 (#1773)
c349a1e 
Bumps [@sentry/browser](https://github.com/getsentry/sentry-javascript) from 6.3.4 to 6.3.5.
- [Release notes](https://github.com/getsentry/sentry-javascript/releases)
- [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md)
- [Commits](getsentry/sentry-javascript@6.3.4...6.3.5)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
fix(deps): bump aws-sdk from 2.895.0 to 2.897.0 (#1776)
6cfe6d6 
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.895.0 to 2.897.0.
- [Release notes](https://github.com/aws/aws-sdk-js/releases)
- [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md)
- [Commits](aws/aws-sdk-js@v2.895.0...v2.897.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump stylelint from 13.13.0 to 13.13.1 (#1775)
f4a58b4 
Bumps [stylelint](https://github.com/stylelint/stylelint) from 13.13.0 to 13.13.1.
- [Release notes](https://github.com/stylelint/stylelint/releases)
- [Changelog](https://github.com/stylelint/stylelint/blob/master/CHANGELOG.md)
- [Commits](stylelint/stylelint@13.13.0...13.13.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump @babel/core from 7.13.16 to 7.14.0 (#1772)
50b4ab1 
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.13.16 to 7.14.0.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.14.0/packages/babel-core)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
fix(deps): bump @sentry/integrations from 6.3.4 to 6.3.5 (#1774)
b8de045 
Bumps [@sentry/integrations](https://github.com/getsentry/sentry-javascript) from 6.3.4 to 6.3.5.
- [Release notes](https://github.com/getsentry/sentry-javascript/releases)
- [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md)
- [Commits](getsentry/sentry-javascript@6.3.4...6.3.5)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
fix(deps): bump fp-ts from 2.10.4 to 2.10.5 (#1781)
ed1da42 
Bumps [fp-ts](https://github.com/gcanti/fp-ts) from 2.10.4 to 2.10.5.
- [Release notes](https://github.com/gcanti/fp-ts/releases)
- [Changelog](https://github.com/gcanti/fp-ts/blob/master/CHANGELOG.md)
- [Commits](gcanti/fp-ts@2.10.4...2.10.5)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump core-js from 3.11.1 to 3.11.2 (#1780)
509a90e 
Bumps [core-js](https://github.com/zloirock/core-js/tree/HEAD/packages/core-js) from 3.11.1 to 3.11.2.
- [Release notes](https://github.com/zloirock/core-js/releases)
- [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md)
- [Commits](https://github.com/zloirock/core-js/commits/v3.11.2/packages/core-js)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@mantariksh
fix: allow commas in email confirmation sender (#1782)
a512b54 
* fix: add quotes around sender name

* docs: add link to relevant GitHub issue

* test: update mail service tests
@karrui
Copy link
Contributor

karrui commented May 4, 2021 •
edited by mantariksh
Loading

@mantariksh

Test

Collapsing public form auth into single endpoint

  • Create a new SP form. Go into the admin panel and key in an invalid eServiceId. Attempt to activate the form. The form should not be activated.
  • Create a new SP form. Go into the admin panel and key in a valid eServiceId. Attempt to activate the form. The form should be activated.
  • Create a new MyInfo form. Go into the admin panel and key in an invalid eServiceId. Attempt to activate the form. The form should not be activated.
  • Create a new MyInfo form. Go into the admin panel and key in a valid eServiceId. Attempt to activate the form. The form should be activated.

@karrui
Copy link
Contributor

karrui commented May 4, 2021 •
edited by mantariksh
Loading

@mantariksh

Tests

implement specific delete form field api

  • Create a field and delete it. The network request should be using the /api/v3 endpoint. Deletion should succeed.

@yong-jie
Copy link
Member Author

yong-jie commented May 4, 2021 •
edited by karrui
Loading

@karrui

Test

Comma bug fix

  • Add an email field with email confirmation. Add a sender string with a comma in it and submit the form. Check that the sender string appears correctly in your email.

@karrui
Copy link
Contributor

karrui commented May 4, 2021 •
edited
Loading

mantariksh tested this

Tests

GSIB IE11 Tests

Intranet IE11 runthrough

  • Create email mode form with all fields and custom start/end page. Activate and submit form. Check that you can receive responses in your intranet inbox.
  • Collaborators can be added in email mode.
  • Create storage mode form with all fields and custom start/end page. Activate and submit form.
  • Response CSV can be downloaded for storage mode.
  • Responses can be viewed in Data tab in storage mode.
  • Attachments for individual fields can be downloaded from Data tab in storage mode.
  • Attachment ZIP for submission can be downloaded from Data tab in storage mode.
  • Submission IDs can be filtered in storage mode.
  • Collaborators can be added and their collaborating rights edited in storage mode.

New features/fixes

  • Field deletion should work properly
  • Public form login to SP form should work properly (can't test SP on GSIB)
  • Public form login to CP form should work properly (can't test CP on GSIB)
  • Public form login to MyInfo form should work properly (can't test MyInfo on GSIB)
  • Add an email field with email confirmation. Add a sender string with a comma in it and submit the form. Check that the sender string appears correctly in your email.

@tshuli
Copy link
Contributor

tshuli commented May 4, 2021 •
edited by karrui
Loading

@karrui

Delete logic

  • Create a form with showField logic. Delete the logic. Check that the build tab is updated.

@yong-jie yong-jie merged commit f3d57cc into release May 5, 2021
@karrui karrui deleted the release-5.9.0 branch August 17, 2021 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mantariksh mantariksh mantariksh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yong-jie @karrui @tshuli @mantariksh @seaerchin