fix: allow commas in email confirmation sender #1782
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We allow admins to specify the email sender for email confirmations. However, when the sender contains a comma, the text before the comma gets cut off.
Example from production
Specifying an email sender with a comma
Actual email sender
Solution
According to this issue, sender names containing commas must be wrapped in quotes. This fixed the problem.
Example from staging
Specifying an email sender with a comma
Actual email sender
Backwards compatibility
Note that for senders without special characters, the email headers actually remain unchanged, so this change is backwards compatible even for receivers which are manually parsing email headers. For senders with special characters, the email headers get fixed by the inclusion of quotes.
Without comma, before (production)
Without comma, after (staging)
With comma, before (production)
With comma, after (staging)
Tests