Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: hotfix release v5.10.1 #1896

Merged
merged 2 commits into from
May 17, 2021
Merged

build: hotfix release v5.10.1 #1896

merged 2 commits into from
May 17, 2021

Conversation

karrui
Copy link
Contributor

@karrui karrui commented May 17, 2021

Hotfix release v5.10.1

This hotfix fixes a bug that affected a small number of forms with an extraneous endPage.buttons key in their form document, where they were unable to update the form's end page values irregardless of what they did due to stricter Joi validation rules on the update endpoint.

The endpoint validation has been loosened whilst pending a DB migration to remove dangling keys that were thought to have been removed.

Closes #1890; thanks @Reevefrombackgate for awareness of this issue!

Fixes

  • fix: allow for unknown keys in updateEndPage validator

@karrui karrui merged commit b6165e8 into release May 17, 2021
@karrui karrui deleted the release-v5.10.1 branch August 17, 2021 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants