feat: extract public form submission flow (and preview) to specific Typescript services #1917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karrui
changed the title
karrui
changed the title
karrui
force-pushed
the
feat/client-public-submission-service
branch
from
8921966
to
5065044
Compare
not needed, but frontend still sends it
shared between preview email form submission in AdminFormService and email form submission PublicFormService
obsolete tests, since they were never being used by the various controllers and were only in the body for the client to choose the correct route.
karrui
force-pushed
the
feat/client-public-submission-service
branch
from
5065044
to
2b31e6e
Compare
|
Ready for review |
mantariksh
reviewed
May 24, 2021
src/app/modules/submission/email-submission/email-submission.controller.ts
Show resolved
Hide resolved
|
@mantariksh ready for rerereview |
mantariksh
approved these changes
May 24, 2021
| const logMeta = { | ||
| action: 'handleEncryptedSubmission', | ||
| action: 'submitEncryptModeForm', |
There was a problem hiding this comment.
haha I still prefer the handle* nomenclature in the backend but that's for another day
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready for review
Problem
This PR extracts out the existing
postfunction insubmissions.client.factory.jsinto their own disparate functions.The original
postfunction used insubmit-form.directiveis now replaced with the exported typescript service functions that has no usages of any angularjs specific effects.This PR also makes
isPreviewkey in submission Joi validator optional, since they were never being used by the various controllers and were only in the body for the client to choose the correct route... The key cannot be removed yet due to old clients sending the key. The extracted functions in this PR no longer sendisPreviewto the server.Closes #1873
Solution
Breaking Changes
Features:
Improvements:
Tests
New unit tests have been written for the new functions
Manual tests