feat: upgrade myinfo-gov-client to 4.0.0 #1925
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades
@opengovsg/myinfo-gov-client
to the latest version, and makes the necessary update to accommodate the breaking changes.The latest version includes a breaking change which makes nested scope data optional (see PR). This is because there is no way of knowing whether a given
MyInfoPerson
data object contains the given nested scopes without knowing which scopes were requested in advance.In FormSG's case,
vehicles.vehicleno
is the only nested scope we deal with, and this property is only accessed if thevehicleno
field is requested, so the property access is safe. Hence the additional?
optional chain was added purely to accommodate the new types frommyinfo-gov-client
.Manual tests