Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set form logo default value when creating form document #1966

Merged
merged 2 commits into from
May 25, 2021

Conversation

karrui
Copy link
Contributor

@karrui karrui commented May 25, 2021

!! Will probably need a DB migration script to populate old forms (that did not update their start pages) with a default form logo state

Problem

Creating a new form does not create a default startPage.logo nested document, resulting in a new form not having a default form logo state.

Screenshot 2021-05-25 at 11 25 52 AM

Screenshot 2021-05-25 at 11 26 30 AM

This PR populates startPage.logo with its default state.

Solution

Breaking Changes

  • Yes - this PR contains breaking changes
    • Details ...
  • No - this PR is backwards compatible
    • If rolled back... just means new documents don't have a default state

Improvements:

  • fix: set default form logo schema on form document creation

Tests

  • tests have been updated

Manual tests

  • Create a new email form. Check that the returned form object from the server now has startPage.logo.state = "DEFAULT"

@karrui karrui requested a review from mantariksh May 25, 2021 03:36
@karrui karrui merged commit 1b2680f into develop May 25, 2021
@karrui karrui deleted the fix/set-logo-default branch August 17, 2021 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants