Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: release v5.12.0 #2041

Merged
merged 33 commits into from
Jun 1, 2021
Merged

build: release v5.12.0 #2041

merged 33 commits into from
Jun 1, 2021

Conversation

yong-jie
Copy link
Member

@yong-jie yong-jie commented Jun 1, 2021

New

  • feat: Deduplicate Mongodb Error Messages #1996
  • feat: display different e-service placeholder text for singpass and corpass #1968

Improved

  • fix(verification): loosen OTP waiting time by 2 seconds #1957
  • fix: add types to RequestHandler in submitEncryptModeForm #1889
  • refactor(verification): migrate otp verification to new v3 routes #1926
  • refactor(verification): migrate otp generation to new api endpoint #1916
  • refactor: Convert form-feedback.client.factory.js, CsvGenerator.js to TypeScript #1899

Dev changes

  • build: upgrade application node version to v14 (by updating Docker image) #2038
  • ref: remove usage of express-serve-static-core types (ParamsDictionary, Query) #1848

Dependency upgrades

  • fix(deps): bump aws-sdk from 2.913.0 to 2.914.0 #1980
  • fix(deps): bump libphonenumber-js from 1.9.18 to 1.9.19 #1979
  • fix(deps): bump opossum from 6.0.1 to 6.1.0 #1976
  • fix(deps): bump aws-sdk from 2.912.0 to 2.913.0 #1974
  • fix(deps): bump aws-sdk from 2.914.0 to 2.916.0 #1985
  • fix(deps): bump @sentry/browser from 6.4.1 to 6.5.0 #2033
  • fix(deps): bump aws-sdk from 2.916.0 to 2.918.0 #1993
  • fix(deps): bump @sentry/integrations from 6.4.1 to 6.5.0 #2036
  • fix: upgrade mongoose from 5.12.5 to 5.12.7 #1977

Dev dependencies

  • chore(deps-dev): bump @types/express-serve-static-core #1973
  • chore(deps-dev): bump @types/node from 14.17.0 to 14.17.1 #1972
  • chore(deps-dev): bump core-js from 3.12.1 to 3.13.0 #1978
  • chore(deps-dev): bump typescript from 4.2.4 to 4.3.2 #1984
  • chore(deps-dev): bump @types/express from 4.17.11 to 4.17.12 #1975
  • chore(deps-dev): bump date-fns from 2.21.3 to 2.22.1 #1992
  • chore(deps-dev): bump @types/mongodb from 3.6.16 to 3.6.17 #1991
  • chore(deps-dev): bump core-js from 3.13.0 to 3.13.1 #1990
  • chore(deps-dev): bump @opengovsg/mockpass from 2.7.0 to 2.7.2 #2031
  • chore(deps-dev): bump eslint-plugin-import from 2.23.3 to 2.23.4 #1995
  • chore(deps-dev): bump @babel/preset-env from 7.14.2 to 7.14.4 #1994
  • chore(deps-dev): bump @typescript-eslint/parser from 4.25.0 to 4.26.0 #2035
  • chore(deps-dev): bump @typescript-eslint/eslint-plugin #2034

mantariksh and others added 30 commits May 25, 2021 15:27
chore: merge v5.11.0 into develop
* fix: add types to RequestHandler in submitEncryptModeForm

* Remove unused FieldResponse type

* address various comments
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 14.17.0 to 14.17.1.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@types/express-serve-static-core](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/express-serve-static-core) from 4.17.19 to 4.17.20.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/express-serve-static-core)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.912.0 to 2.913.0.
- [Release notes](https://github.com/aws/aws-sdk-js/releases)
- [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md)
- [Commits](aws/aws-sdk-js@v2.912.0...v2.913.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@types/express](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/express) from 4.17.11 to 4.17.12.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/express)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [opossum](https://github.com/nodeshift/opossum) from 6.0.1 to 6.1.0.
- [Release notes](https://github.com/nodeshift/opossum/releases)
- [Changelog](https://github.com/nodeshift/opossum/blob/main/CHANGELOG.md)
- [Commits](nodeshift/opossum@v6.0.1...v6.1.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [libphonenumber-js](https://gitlab.com/catamphetamine/libphonenumber-js) from 1.9.18 to 1.9.19.
- [Release notes](https://gitlab.com/catamphetamine/libphonenumber-js/tags)
- [Changelog](https://gitlab.com/catamphetamine/libphonenumber-js/blob/master/CHANGELOG.md)
- [Commits](https://gitlab.com/catamphetamine/libphonenumber-js/compare/v1.9.18...v1.9.19)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.913.0 to 2.914.0.
- [Release notes](https://github.com/aws/aws-sdk-js/releases)
- [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md)
- [Commits](aws/aws-sdk-js@v2.913.0...v2.914.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [core-js](https://github.com/zloirock/core-js/tree/HEAD/packages/core-js) from 3.12.1 to 3.13.0.
- [Release notes](https://github.com/zloirock/core-js/releases)
- [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md)
- [Commits](https://github.com/zloirock/core-js/commits/v3.13.0/packages/core-js)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…1916)

* docs(verification): adds deprecation notice

* feat(verification): add new backend route for generating otp

* feat(fieldverificationservice): add new frontend call for generating otp

* feat(verifiab-field-component): adds field type to component

* fix(fieldverificationservice): exports otp function agian

* docs(public-forms/verification/controller): added extra docs

* feat(verification/controller): added stronger validation

* docs(verification): updated docs for otp generation

* test(verification-controller/spec): adds unit tests for controlelr

* test(fieldverificationservice/test): updated tests for triggerSendOtp

* chore(verifiable-field.client.component): removed console log

* refactor(verification): removed fieldtype and let verification be more permissive

* docs(verification/controller): add docs for steps

* fix(verification/controller): removed fieldType from joi validation

* test(integration): integration tests for generate otp (#1924)

* feat(tests/integration/helpers): add new test helpers for nodmailer and twilio

* test(verification/routes): added integration tests for generating otp

* chore(tests/integration/helpers): removed nodemailer helper

* test(public-forms/verification/routes): updated to not use mock nodemailer

* test(public-forms/verification/routes/spec): adds missing import

* test(public-forms/verification/routes): fixed test for expired  transaction

* test(public-forms/verification/routes): removed fieldType from integration tests

* refactor(verification): fixed wording for tests and when email couldn't be send

* test(verification): fixed tests after wording change
)

* refactor(fieldverificationservice): updated verifyOtp to new parameters and updated tests

* docs(verification): adds deprecation notice for verifyOtp

* feat(verification): adds new controller method and route for otp verification

* refactor(verifiable-field): updated call site for verify otp

* test(verification/controller/spec): adds unit tests for handleOtpVerification

* docs(public-forms/verification/routes): adds docs for otp verification

* docs(verification/controller): add docs for otp verification

* test(verification): integration tests for otp verification (#1928)

* test(public-forms/verification/routes/spec): adds integration tests for otp verification

* docs(public-forms/verification/routes/test): fixed typo

* refactor(public-forms/verifaction/routes/spec): changed to generating otp instead of mocking hash
Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.2.4 to 4.3.2.
- [Release notes](https://github.com/Microsoft/TypeScript/releases)
- [Commits](microsoft/TypeScript@v4.2.4...v4.3.2)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.914.0 to 2.916.0.
- [Release notes](https://github.com/aws/aws-sdk-js/releases)
- [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md)
- [Commits](aws/aws-sdk-js@v2.914.0...v2.916.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [core-js](https://github.com/zloirock/core-js/tree/HEAD/packages/core-js) from 3.13.0 to 3.13.1.
- [Release notes](https://github.com/zloirock/core-js/releases)
- [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md)
- [Commits](https://github.com/zloirock/core-js/commits/v3.13.1/packages/core-js)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@types/mongodb](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/mongodb) from 3.6.16 to 3.6.17.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/mongodb)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [date-fns](https://github.com/date-fns/date-fns) from 2.21.3 to 2.22.1.
- [Release notes](https://github.com/date-fns/date-fns/releases)
- [Changelog](https://github.com/date-fns/date-fns/blob/master/CHANGELOG.md)
- [Commits](date-fns/date-fns@v2.21.3...v2.22.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.916.0 to 2.918.0.
- [Release notes](https://github.com/aws/aws-sdk-js/releases)
- [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md)
- [Commits](aws/aws-sdk-js@v2.916.0...v2.918.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.14.2 to 7.14.4.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.14.4/packages/babel-preset-env)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [eslint-plugin-import](https://github.com/benmosher/eslint-plugin-import) from 2.23.3 to 2.23.4.
- [Release notes](https://github.com/benmosher/eslint-plugin-import/releases)
- [Changelog](https://github.com/benmosher/eslint-plugin-import/blob/master/CHANGELOG.md)
- [Commits](import-js/eslint-plugin-import@v2.23.3...v2.23.4)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@opengovsg/mockpass](https://github.com/opengovsg/mockpass) from 2.7.0 to 2.7.2.
- [Release notes](https://github.com/opengovsg/mockpass/releases)
- [Commits](opengovsg/mockpass@v2.7.0...v2.7.2)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@sentry/browser](https://github.com/getsentry/sentry-javascript) from 6.4.1 to 6.5.0.
- [Release notes](https://github.com/getsentry/sentry-javascript/releases)
- [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md)
- [Commits](getsentry/sentry-javascript@6.4.1...6.5.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@sentry/integrations](https://github.com/getsentry/sentry-javascript) from 6.4.1 to 6.5.0.
- [Release notes](https://github.com/getsentry/sentry-javascript/releases)
- [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md)
- [Commits](getsentry/sentry-javascript@6.4.1...6.5.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
frankchn and others added 3 commits May 31, 2021 22:30
* feat: Deduplicate Mongodb Error Messages

* Update src/app/utils/handle-mongo-error.ts

Co-authored-by: Yuan Ruo <yuanruo@data.gov.sg>

* Fix ts lint error

Co-authored-by: Yuan Ruo <yuanruo@data.gov.sg>
…age) (#2038)

* build: upgrade node to Fermium LTS (v14)

* build: update references in Travis and Actions to node v14

* chore: update doc references to node v14

also update mongo base version

* fix: update stream tests to promisified version

seems to be failing due to node upgrade, but i don't know why. Does not seem to fail when manual testing, so should be some jest x node implementation on streams
@yong-jie
Copy link
Member Author

yong-jie commented Jun 1, 2021

@yong-jie

Tests

  • Change authentication method to Singpass and Singpass(MyInfo). Placeholder text should show "Enter Singpass e-service ID".
  • Change authentication method to Singpass(Corporate). Placeholder text should show "Enter Corppass e-service ID"

@yong-jie
Copy link
Member Author

yong-jie commented Jun 1, 2021

@yong-jie

Manual tests

  • Request for an OTP for a verified field. When the 30 second timer on the UI elapses, immediately request a new one. The request should be valid and you should receive the new OTP.

@yong-jie
Copy link
Member Author

yong-jie commented Jun 1, 2021

Manual Tests

@tshuli

  • Create a form with a verifiable mobile field and publish it. Go to the form, and verify with a valid mobile number. There should be an OTP generated
  • Follow the above and then verify and submit. , but on successful otp generation submission, go to the networks tab in the developer panel and copy as fetch for the request. Change the fieldType to something else. This should fail. Change the answer property to be an invalid number. this should also fail
  • Create a form with a verifiable email field and publish it. Go to the form, and verify with a valid email. There should be an OTP generated
  • Follow the above and then verify and submit. , but on successful otp generation submission, go to the networks tab in the developer panel and copy as fetch for the request. Change the fieldType to something else. This should fail. Change the answer property to be an invalid email. this should also fail.

@yong-jie
Copy link
Member Author

yong-jie commented Jun 1, 2021

@yong-jie

Tests

  • Create email mode form. Check that feedback tab shows no feedback received.
  • Check that form feedback can be submitted successfully. Do this several times.
  • Check that submitted feedback and count appears correctly on feedback tab.
  • Check that submitted feedback can be downloaded.
  • Repeat above with storage mode form.

@yong-jie yong-jie merged commit 44bcf03 into release Jun 1, 2021
@karrui karrui deleted the release-5.12.0 branch August 17, 2021 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants