ref: remove usage of express-serve-static-core types (ParamsDictionary, Query) #1848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
now that everything is exported from the 'express' package, no more need for the base types
mantariksh
reviewed
May 11, 2021
loosening allows any type that extends from express#Request to be passed to the utility functions. This does not matter since the utilities do not use the types params that are being supplied to the interface
also add some missing param types, remove some typecasts
|
Will reopen when types are fixed in #1854 |
# Conflicts: # src/app/modules/form/admin-form/admin-form.controller.ts # src/app/modules/submission/encrypt-submission/encrypt-submission.controller.ts # src/app/modules/verification/verification.controller.ts
# Conflicts: # package.json # src/app/modules/verification/verification.controller.ts
mantariksh
approved these changes
Jun 1, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR creates a new
ControllerHandlerinterface that extends fromexpress#RequestHandlerinterface but replaces all theanycasts tounknown, for stricter typing. With that, the dependency@types/express-serve-static-coreis no longer needed and removed from the application.This PR is however blocked by #1854 as
submitEncryptModeFormhas no typings and will now throw a compiler error due to the stricterunknowntype (fromany). Will be merged in when that issue is resolved.Closes #948
Solution
Features:
Improvements:
utils/request.ts@types/express-serve-static-coreby updating types usedDependencies:
@types/express-serve-static-core