build: upgrade application node version to v14 (by updating Docker image) #2038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karrui
changed the title
mantariksh
approved these changes
Jun 1, 2021
|
GAH thought i caught them all, thanks anti |
|
also update mongo base version
yong-jie
approved these changes
Jun 1, 2021
seems to be failing due to node upgrade, but i don't know why. Does not seem to fail when manual testing, so should be some jest x node implementation on streams
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The current base node Docker image used in our application has a possible security vulnerability as flagged by Snyk (Improper certificate validation), which can cause the Node process to terminate. This can result in denial of service.
This PR upgrades the Docker image to
node:fermium-alpine3.13, which upgrades our node version used to v14. The image does not seem to have any known vulnerabilities flagged.Tested on staging.
Closes #2027
Solution
Improvements: