fix: return storage mode submission version when when retrieving from server #2112
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, the encrypted submission object returned does not return the version number, whilst
formsg-javascript-sdk#decrypt
requires the version number in the param (but not used since we only have 1 version so far).This bug does not affect prod, since the
version
parameter is actually unused by the SDK. This is to prevent future updates from breaking and to correctly return expected required parameters when retrieving storage mode responses.This PR returns the version number when retrieving submission (meta)data regardless so that the decrypt call doesn't need a mock version number parameter.
Closes #2029
Solution
Breaking Changes
Bug Fixes:
Tests
Tests have been updated to account for the new
version
key returned.Manual test