Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): remove distinction between basic and full env #2128

Merged
merged 1 commit into from
Jun 10, 2021

Conversation

mantariksh
Copy link
Contributor

@mantariksh mantariksh commented Jun 10, 2021

Problem

The end-to-end tests currently distinguish between "basic environment" and "full environment" tests to ensure that the open-source version of the product (without any optional env vars) works correctly. However, this is no longer a requirement since the feature manager is being removed.

Part of #1842

Solution

Remove the distinction between the two environments. All end-to-end tests are now run with the full suite of environment variables.

Breaking Changes

  • Yes - this PR contains breaking changes
    • Details ...
  • No - this PR is backwards compatible
    • Tests only

@mantariksh mantariksh requested review from karrui and tshuli June 10, 2021 03:18
@mantariksh mantariksh merged commit 2a31356 into develop Jun 10, 2021
@mantariksh mantariksh deleted the test/remove-e2e-basic-env branch June 15, 2021 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants