Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Release 5.19.1 #2342

Merged
merged 2 commits into from
Jul 8, 2021
Merged

build: Release 5.19.1 #2342

merged 2 commits into from
Jul 8, 2021

Conversation

tshuli
Copy link
Contributor

@tshuli tshuli commented Jul 8, 2021

Release 5.19.1

Deploy notes

  • new env var of OLD_SPCP_COOKIE_DOMAIN should be set to .form.gov.sg for prod at the time of deployment (done)
  • existing env var of SPCP_COOKIE_DOMAIN should be changed to blank for prod at time of deployment (done)

New Env Vars

  • Added new env var OLD_SPCP_COOKIE_DOMAIN for client to delete old cookie.

Release Summary

New

  • feat(auth): support sgID for form submissions #1986

Improvements

  • feat: Set SP/CP JWT cookie to HttpOnly #2193
  • feat: client to delete spcp cookie #2328
  • refactor: revert the revert of encapsulate parsedResponses #2278

Fixes

  • feat: Remove self from collaborator list #2212
  • fix: allow duplicating email field with PDF to storage mode #2303

Dependency Changes

  • fix(deps): bump aws-sdk from 2.936.0 to 2.937.0 #2287
  • fix(deps): bump aws-sdk from 2.937.0 to 2.939.0 #2293
  • fix(deps): bump express-rate-limit from 5.2.6 to 5.3.0 #2288
  • fix(deps): bump libphonenumber-js from 1.9.20 to 1.9.21 #2291
  • fix(deps): bump neverthrow from 4.2.1 to 4.2.2 #2297
  • fix(deps): bump twilio from 3.64.0 to 3.65.0 #2284
  • fix(deps): bump zod from 3.2.0 to 3.3.3 #2296
  • fix(deps): bump zod from 3.3.3 to 3.3.4 #2299
  • fix(deps): unpin typescript #2305
  • chore(deps-dev): bump @types/mongodb from 3.6.18 to 3.6.19 #2286
  • chore(deps-dev): bump @types/uuid from 8.3.0 to 8.3.1 #2294
  • chore(deps-dev): bump @types/validator from 13.1.4 to 13.6.2 #2298
  • chore(deps-dev): bump @typescript-eslint/eslint-plugin #2307
  • chore(deps-dev): bump @typescript-eslint/parser from 4.28.1 to 4.28.2 #2306
  • chore(deps-dev): bump eslint from 7.29.0 to 7.30.0 #2295
  • chore(deps-dev): bump ts-node-dev from 1.1.7 to 1.1.8 #2285

tshuli and others added 2 commits July 8, 2021 09:56
@tshuli
feat: client to delete spcp cookie (#2328)
360ac2a 
* feat: client to delete cookie

* chore: add env var for old domain name

* doc: add comment

* chore: add oldSpcpCookieDomain to environment

* fix: undefined cookieName
@tshuli
chore: bump version to 5.19.1
cec0e19
@tshuli tshuli requested a review from mantariksh July 8, 2021 02:54
@tshuli tshuli mentioned this pull request Jul 8, 2021
Closed
@tshuli tshuli changed the title Release 5.19.1 build: Release 5.19.1 Jul 8, 2021
@tshuli
Copy link
Contributor Author

tshuli commented Jul 8, 2021

Tests

  • Create sp form and log in
    • In dev tools, add a . prefix to the cookie domain (.staging.form.gov.sg) and change HttpOnly to false
    • Check that form can be submitted
    • Check that user can log out and jwt cookie is deleted thereafter
    • Log in again. Check that submission and log out works
  • Repeat above with 'remember me' enabled
  • Repeat above with CP form

@tshuli tshuli merged commit 31affa0 into release Jul 8, 2021
@tshuli tshuli deleted the release-5.19.1 branch July 8, 2021 05:49
@tshuli tshuli restored the release-5.19.1 branch July 8, 2021 05:49
@karrui karrui deleted the release-5.19.1 branch August 17, 2021 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mantariksh mantariksh mantariksh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tshuli @mantariksh