-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove form_field.isFutureOnly key #235
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you also include a db script to remove the old key? as recent experience has shown, we should avoid leaving old keys dangling
e136477
to
da234d1
Compare
da234d1
to
b4ff882
Compare
Have you been committing with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes, I'll leave it to @mantariksh to really review the script ><
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sorry for the many separate comments, basically just try again on localhost and see if any errors pop up |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Problem
Closes #40
Tests
Create 5 date fields in admin view with the following options. Test that the validations work in the preview panel datepicker on the right (i.e. the popup calendar).
Validation for date range validation option in admin view
Able to submit forms correctly
Test for editing and reordering, instead of creating
Scripts