Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove filetype from permission levels imports #236

Merged
merged 1 commit into from
Sep 1, 2020
Merged

fix: remove filetype from permission levels imports #236

merged 1 commit into from
Sep 1, 2020

Conversation

mantariksh
Copy link
Contributor

Problem

Imports for src/app/utils/permission-levels are broken after TS migration.

Solution

Remove filetype from imports.

karrui
karrui approved these changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@karrui karrui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, do we have other instances of this on other refactor? :(

@mantariksh
Copy link
Contributor Author

hmm, I checked for imports ending with .js, but let me check for .default in imports before merging

@mantariksh
Copy link
Contributor Author

also worth investigating how tests passed

@mantariksh
Copy link
Contributor Author

ok did a check of our default exports, seems good to go

@mantariksh mantariksh merged commit 4b89d9c into develop Sep 1, 2020
@liangyuanruo liangyuanruo deleted the fix-permission-levels branch September 2, 2020 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karrui karrui karrui approved these changes

@arshadali172 arshadali172 Awaiting requested review from arshadali172

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mantariksh @karrui