Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: release v5.19.2 - fixes for SGID and MyInfo cookies #2372

Merged
merged 4 commits into from
Jul 12, 2021
Merged

build: release v5.19.2 - fixes for SGID and MyInfo cookies #2372

merged 4 commits into from
Jul 12, 2021

Conversation

mantariksh
Copy link
Contributor

Fixes

  • fix: allow myinfo authtype for logout #2362
  • fix(BetaService): make SGID form-level beta feature #2369
  • fix(SGID): add sgid to User schema beta flags #2371

mantariksh and others added 4 commits July 12, 2021 15:42
@mantariksh
fix(SGID): add sgid to User schema beta flags (#2371)
8675dd7
@mantariksh
fix(BetaService): make SGID form-level beta feature (#2369)
ab4b886 
* fix(BetaService): make SGID form-level beta feature

* chore: remove outdated comment

* fix: check for user access to SGID

* fix: return authType when retrieving single example

Users without SGID beta flag were not being prevented from creating SGID
forms because the single example endpoint was not retrieving the authType,
resulting in the frontend being unable to detect when the form is an SGID
form.

* fix: return authType when retrieving list of examples

* test: update examples tests
@tshuli
fix: allow myinfo authtype for logout (#2362)
8ecfec0
@mantariksh
chore: bump version to 5.19.2
588730c
@mantariksh
Copy link
Contributor Author

mantariksh commented Jul 12, 2021 •
edited by tshuli
Loading

Tests

  • Create myinfo form and publish. Login. Check that you can logout before submission and MyInfoCookie is deleted
  • Login again. Check that you can submit, and you are auto logged out after submission
  • Creating non-SGID form from Examples page works
  • Creating non-SGID form from template works
  • Duplicating non-SGID form works
  • Creating SGID form from template does not work (assuming user does not have SGID beta flag)
  • Unable to change to SGID option when beta flag is missing
  • Able to change to SGID option when beta flag is present
  • Logout works for SP, CP and SGID

@mantariksh mantariksh merged commit c2bf074 into release Jul 12, 2021
@karrui karrui deleted the release-v5.19.2 branch August 17, 2021 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tshuli tshuli tshuli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mantariksh @tshuli