build: hotfix release v5.21.2, remove esrvcId validation when logging form logins #2484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TestsStaging tests
Unable to test the rest as we don't have an esrvcId with underscores. Prod Manual tests
|
not needed, and part of the incomplete hotfix undertaken in #2470
mantariksh
approved these changes
Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hotfix release v5.21.2
This release fixes the bug where users would be unable to log into Singpass/Corppass forms if the form's
esrvcIdcontains an underscore, due to esrvcId validation on theloginmodel not being updated in tandem with the new esrvcId format.This release removes the validation for a form's
esrvcIdwhen logging public form logins to thelogincollection. This hotfix builds on #2470.