refactor: typify webhook and migrate from middleware pattern #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arshadali172
changed the title
karrui
requested changes
Sep 1, 2020
added 9 commits
September 1, 2020 18:04
arshadali172
force-pushed
the
webhook-migration
branch
from
f0029df
to
46abbf7
Compare
added 8 commits
September 1, 2020 18:08
…discriminator model itself
karrui
approved these changes
Sep 2, 2020
karrui
reviewed
Sep 2, 2020
| res: Response, | ||
| next: NextFunction, | ||
| ) => { | ||
| // TODO: Once we move away from the middleware pattern, there should not be a webhook controller |
There was a problem hiding this comment.
I meant as in TODO(#149): .... but ok la can see reference in github haha
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Partially addresses #144
Solution
pushDataand tests are refactored accordingly