Revert "refactor: use modern JS constructs to validate NRIC" #2836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mantariksh
approved these changes
Sep 21, 2021
|
@timotheeg think you might need to add a |
…)" This reverts commit aaa8072.
timotheeg
force-pushed
the
revert-2785-refactoring/nirc_regex_improvements
branch
from
3ecb698
to
9476c7e
Compare
timotheeg
deleted the
revert-2785-refactoring/nirc_regex_improvements
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #2785
The PR was not compatible with IE11, which is not acceptable for end users.
Reverting now, to keep
develop:HEADrelease-clean. The PR will be re-introduced once it has been made compatible.@mantariksh @tshuli