feat: merge release 4.34.1 into develop #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor: move bounce model into module * refactor: inline tests * refactor: move helpers into util * feat: log admin responses to main log group * feat: log all critical bounces * refactor: use absolute paths in tests * fix: fix constants import * feat: log submission ID for critical bounces * test: allow varying email type * test: update tests for bounce service * test: ignore __tests__ for coverage * test: add test for short term logs * build: ignore tests for compilation * refactor: rename bounce-helpers to bounce-test-helpers * refactor: avoid using lodash get * refactor: convert EMAIL_TYPES to enum * refactor: change log action to calling method * refactor: change CRITICAL BOUNCE to sentence case * refactor: move isCriticalBounce into domain * refactor: move typeguards into util * refactor: avoid typecast for IBounceNotification * refactor: call logCriticalBounce only once * refactor: remove setting of hasAlarmed * refactor: extract function for logging raw notif * docs: add TODO to convert bounceType to enum * refactor: use typeguard to check recipients * fix: convert formId to string * fix: set hasAlarmed * refactor: collapse save calls * refactor: add bounceInfo key explicitly
tshuli
approved these changes
Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.