refactor: use res.json if backwards compatible with client #426
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Usage of
res.send
creates the risk of HTML injection attacks if not used with care. Usingres.json
is better practice.Solution
This PR addresses the cases where changing from
res.status
tores.json
is compatible with the client.When the client does not use the content of the response body, it is safe to change
res.send
tores.json
, wrapping the original string in an object. For example, the client sometimes does its own success/error handling, or simply logs errors to the console. This applies to the following API endpoints:GET /billing
POST /:formId/adminform/feedback
POST /:formId/feedback
GET /spcp/redirect
GET /spcp/validate
GET /auth/signout
GET /user
celebrate
errors