Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: early return when validating empty email string #433

Merged
merged 1 commit into from
Oct 8, 2020

Conversation

karrui
Copy link
Contributor

@karrui karrui commented Oct 8, 2020

Problem

Fixes bug where optional email fields are still failing validation for restricted email domains even when they are empty.

Closes #431

Solution

Bug Fixes:

  • Remove restricted email domain field validation when field is an empty string (on required fields, the required validator will still fire)

After Screenshots

AFTER:

Required fields will have error when field is empty when submitting
Screenshot 2020-10-08 at 12 31 13 PM

Optional field will have no error when field is empty when submitting
Screenshot 2020-10-08 at 12 31 37 PM

@karrui karrui merged commit d8bbdd1 into develop Oct 8, 2020
@karrui karrui deleted the fix/optional-restricted-fields branch October 8, 2020 04:49
@karrui karrui mentioned this pull request Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Optional email field with restricted email domains will prevent submission
3 participants