refactor: migrate isSpcpAuthenticated to TypeScript #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mantariksh
force-pushed
the
ref/ts-spcp-is
branch
from
c44b02a
to
88c946f
Compare
mantariksh
added a commit
that referenced
this pull request
Nov 19, 2020
* ref: add mapRouteError case for VerifyJwtError * ref: add mapRouteError case for InvalidAuthType * ref: implement isSpcpAuthenticated * ref: remove old isSpcpAuthenticated * ref: use new isSpcpAuthenticated * test: remove unused tests
28 tasks
mantariksh
added a commit
that referenced
this pull request
Nov 23, 2020
* ref: add mapRouteError case for VerifyJwtError * ref: add mapRouteError case for InvalidAuthType * ref: implement isSpcpAuthenticated * ref: remove old isSpcpAuthenticated * ref: use new isSpcpAuthenticated * test: remove unused tests
mantariksh
added a commit
that referenced
this pull request
Nov 23, 2020
* refactor: standardise usage of getUniqueMyInfoAttrs (#636) * ref: migrate /spcp/redirect endpoint to TypeScript (#635) * refactor: migrate /spcp/validate to TypeScript (#656) * refactor: migrate addSpcpSessionInfo to TypeScript (#664) * refactor: migrate isSpcpAuthenticated to TypeScript (#666) * refactor: create addLoginFromForm static method (#679) * refactor: move passThroughSpcp business logic into service (#667) * refactor: migrate SPCP /login endpoints to TypeScript (#680) * refactor: migrate appendVerifiedSpcpResponses to TypeScript (#693) * docs: add docs for all new functions (#696) * test: add tests for SPCP login endpoints (#695) * feat: log login HTML * fix: change title check to null-only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #665
This PR migrates the
isSpcpAuthenticatedmiddleware to TypeScript by taking advantage of theextractJwtPayloadfunction implemented in #664. The old controller tests were removed and new ones have not been added yet, since theisSpcpAuthenticatedmiddleware will soon be subsumed under new controllers for the Submissions endpoints.