Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Release v4.46.1 hotfix #681

Merged
merged 3 commits into from
Nov 19, 2020
Merged

build: Release v4.46.1 hotfix #681

merged 3 commits into from
Nov 19, 2020

Conversation

karrui
Copy link
Contributor

@karrui karrui commented Nov 19, 2020 •
edited
Loading

Fixes

  • fix: check for undefined-ness on attachmentMetadata
  • fix: early return on undefined verification signature

@karrui karrui requested review from mantariksh and tshuli and removed request for mantariksh November 19, 2020 02:30
tshuli
tshuli previously approved these changes Nov 19, 2020
View reviewed changes
Copy link
Contributor

@tshuli tshuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@karrui karrui merged commit 561a538 into release Nov 19, 2020
@liangyuanruo liangyuanruo deleted the release-v4.46.1-hotfix branch January 14, 2021 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liangyuanruo liangyuanruo liangyuanruo approved these changes

@tshuli tshuli tshuli left review comments

@mantariksh mantariksh Awaiting requested review from mantariksh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karrui @liangyuanruo @tshuli