Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Revert remove eb shift frontend feature flags (#6869) #6909

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

tshuli
Copy link
Contributor

@tshuli tshuli commented Nov 17, 2023

  • This reverts commit d5bbb4d so that we can continue to use the fallback route
  • This is because GSIB attachment uploads via s3 presigned URL are blocked
  • Pending a more permanent fix

Tests

Regression

Ensure that email submissions are working
  • On GSIB, submit email form with no attachment. Submission should work
  • On GSIB, submit email form with attachment. Submission should work
  • On GSIB, submit storage form with 2 attachments. Submission should work
    • with .txt files
    • with .pdf files
    • with .zip files

Hotfix cases

  • On GSIB, submit storage form with no attachment. Submission should work
  • On GSIB, submit storage form with attachment. Submission should work
  • On GSIB, submit storage form with 2 attachments. Submission should work
    • with .txt files
    • with .pdf files
    • with .zip files

@tshuli tshuli force-pushed the fix/revert-eb-shift-frontend branch from be15d56 to 9fdfe00 Compare November 17, 2023 14:45
@tshuli tshuli changed the title chore: Revert "chore: remove eb shift frontend feature flags (#6869)" chore: Revert remove eb shift frontend feature flags (#6869) Nov 17, 2023
@KenLSM KenLSM self-requested a review November 17, 2023 14:54
@tshuli tshuli changed the base branch from develop to release-al2 November 17, 2023 15:04
@tshuli tshuli force-pushed the fix/revert-eb-shift-frontend branch from 9fdfe00 to efab3cf Compare November 17, 2023 15:05
@tshuli tshuli changed the title chore: Revert remove eb shift frontend feature flags (#6869) hotfix: Revert remove eb shift frontend feature flags (#6869) Nov 17, 2023
@tshuli tshuli changed the title hotfix: Revert remove eb shift frontend feature flags (#6869) chore: Revert remove eb shift frontend feature flags (#6869) Nov 17, 2023
Copy link
Contributor

@KenLSM KenLSM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tshuli tshuli merged commit 67cfa78 into release-al2 Nov 17, 2023
32 of 33 checks passed
@tshuli tshuli deleted the fix/revert-eb-shift-frontend branch November 17, 2023 15:36
@tshuli tshuli mentioned this pull request Nov 20, 2023
12 tasks
@tshuli tshuli restored the fix/revert-eb-shift-frontend branch January 2, 2024 07:27
@KenLSM KenLSM deleted the fix/revert-eb-shift-frontend branch August 30, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants