Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: release v6.91.0 #6918

Merged
merged 5 commits into from
Nov 21, 2023
Merged

build: release v6.91.0 #6918

merged 5 commits into from
Nov 21, 2023

Conversation

KenLSM
Copy link
Contributor

@KenLSM KenLSM commented Nov 21, 2023

New

  • fix(markdown): refine regex to handle newlines after indentation groups #6917
  • fix: omit isVisible property from webhook response #6907
  • feat: charts #6790
  • build: merge release 6.90.0 to develop #6914
  • build: release v6.90.0 #6913

Dependencies

Dev-Dependencies

Tests

fix: omit isVisible property from webhook response #6907

@KenLSM

  • Create a storage mode form, with at least 1 of the following fields: short text field, Myinfo field, verified field, heading, attachment
  • Set up a webhook server and update the webhook url in the form's settings
  • Submit the form, check that the responses are decrypted by the webhook server and do not contain isVisible

feat: charts #6790

Regression Tests

Ensure viewing of storage form submission results

@tshuli

  • Go to a storage mode form results page
  • Enter secret key for form
  • Ensure that results page can be entered
  • Ensure that results page renders table with results
  • Click on an entry
  • Ensure that results page is showing individual results

Deploy Notes

New dependencies:

  • react-wordcloud : to render wordcloud on react
  • stopword: to remove stopwords for wordcloud
  • react-google-charts: wrapper to google charts

New dev dependencies:

  • @types/stopword : types for stopword

KenLSM and others added 5 commits November 20, 2023 16:18
build: merge release 6.90.0 to develop
* chore: import react google charts

* feat: create skeleton insights page

* fix: regex for route matching for insight page

* fix: layout of insights page

* feat: dummy endpoint for all encrypted data

* feat: queries to get all encrypted submission

* fix: encrypted model find params

* feat: get and decrypted all submission data

* feat: get formfields

* feat: generate charts

* fix: typing of spacing

* feat: create mapping for field to charts

* feat: some upgrades to format charts

* feat:wordcloud

* fix: remove excess divider

* fix: prefill rating values in bar chart

* feat: add question number to chart title

* feat: skeleton for changing chart to table

* chore: add gstatic charts to csp policy

* fix: rating average counting

* feat: table toggle mode

* feat: use icon button instead of toggle

* feat: dummy date picker

* fix: better date range picker styling

* feat: date range filtering

* fix: do not show rating if no values

* fix: filtering by date and styling

* fix: increase size of charts

* fix: do not display wordcloud if no words

* fix: alignment of wordcloud title

* fix: typing for submission insights dto

* refactor: make code more readable

* fix: typing of render array

* fix: do not randomize color for rating

* feat: fix bar graph colours changing on refocus

* feat: fix random word cloud movements on re-render

* feat: address MR comments

* feat: corrected types and fixed lint comments

* feat: update average rating to account for division by 0

* feat: refactored filter function to remove redundant date parsing

* feat: set max words for word cloud

* fix: fe lint issue

* refactor: cleanup constants

* feat: add growthbook toggle

* fix: flickering pie chart tooltip

* fix: ordering of frontend/package.json

* chore: add utils

* feat: add empty insights field

* fix: typeerror on admin submission

* refactor: rename insights to charts

* feat: add beta badge

* refactor: secretkeyverification to common component for results and charts tab

* fix: table charts ui

* fix: charts secretkeyvewrification component

* fix: remove stray space between charts and badge on tab title

* fix: remove testing flag

* chore: update copy for no charts generted

* fix: endday not calculated correctly

* feat(be): add limit and reverse chrono sort for submissions query

* feat(fe): add forced redirect for email charts

* chore: update charts supported field for better visual alignment with secret key section

* feat: add marketing prompts for charts

* chore: add copy for 1000 chart limit

* chore: shorten copy

* refactor: create daterangepicker helpers

* refactor: use helpers from daterangepicker

* feat: add no charts prompt

* chore: update language to omit implication of uncertainty

* fix: number typo

* feat: correctly retrieve based on date range

* fix: remove incorrect generic

* fix: remove unnecessary comment

---------

Co-authored-by: Timothee Groleau <timothee.groleau@gmail.com>
Co-authored-by: sebastianwzq <sebastian@open.gov.sg>
Co-authored-by: Ken <ken@open.gov.sg>
Co-authored-by: tshuli <shuli@open.gov.sg>
…ps (#6917)

fix: refine regex to handle newlines after indentation groups
@KenLSM KenLSM requested a review from tshuli November 21, 2023 07:44
@KenLSM KenLSM merged commit d98f05c into release-al2 Nov 21, 2023
56 of 58 checks passed
@KenLSM KenLSM deleted the release_v6.91.0 branch November 21, 2023 08:39
tshuli added a commit that referenced this pull request Nov 21, 2023
@KenLSM KenLSM mentioned this pull request Nov 28, 2023
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants