Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: payments thank you page preview and edit mode #6969

Merged
merged 17 commits into from
Feb 20, 2024

Conversation

kathleenkhy
Copy link
Contributor

@kathleenkhy kathleenkhy commented Dec 20, 2023

Problem

Currently, the thank you page for payment forms are not editable and users will only be able to use the default title and paragraph text provided for the thank you page. The preview of the thank you page should also reflect the new designs for the thank you page for payment forms.

Closes FRM-1560, FRM-1597, FRM-1572

Solution

To allow the thank you page for payment forms to be editable

Breaking Changes

  • No - this PR is backwards compatible

Before & After Screenshots

BEFORE:
image

AFTER:
image

Tests

Payments Form

Ensure that design is updated in Edit mode
  • Add a payment variable to a form
  • Check that the Thank You page shows the latest design
  • The Button text and Button redirect link should be disabled
  • The text should still be within the Summary table if the product name is very long
  • Upon clicking the Save proof of payment button, the page should be refreshed/ reloaded
Ensure that design is updated in Preview mode
  • Click on the Preview (eye) button of the form in admin mode
  • Check that the Thank You page shows the latest design
  • The text should still be within the Summary table if the product name is very long
  • Upon clicking the Save proof of payment button, the page should be refreshed/ reloaded
Thank you page happy flow with actual form
  • Click on the share button to launch theform
  • Complete the payment flow and submit the form
  • Check that the Thank You page shows the latest design
  • The text should still be within the Summary table if the product name is very long
  • Upon clicking the Save proof of payment button, the invoice PDF should be downloaded

Non-Payments Form

In Edit Mode
  • Remove the payment variable/ component of the form
  • Check that the Thank You page should reflect the default non-payment Thank you page
  • Upon clicking the Save proof of payment button, the page should be refreshed/ reloaded
In Preview Mode
  • Click on the Preview (eye) button of the form in admin mode
  • Check that the Thank You page shows the default, non-payment design
  • Upon clicking the Save proof of payment button, the page should be refreshed/ reloaded
In Actual Form
  • Click on the share button to launch the form
  • Check that the Thank You page shows the default, non-payment design
  • Upon clicking the Submit another response button, the form should be refreshed to show a new form

@kathleenkhy kathleenkhy changed the title Feat/payments thank you preview feat:payments thank you preview Dec 20, 2023
@kathleenkhy kathleenkhy changed the title feat:payments thank you preview feat: payments thank you page preview and edit mode Dec 20, 2023
@kathleenkhy kathleenkhy force-pushed the feat/payments-thank-you-preview branch 3 times, most recently from 7e58ff5 to 00946a4 Compare January 23, 2024 08:33
@kathleenkhy kathleenkhy force-pushed the feat/payments-thank-you-preview branch from 00946a4 to 8e6cc42 Compare January 23, 2024 08:38
@kathleenkhy kathleenkhy marked this pull request as ready for review January 27, 2024 14:29
@kathleenkhy kathleenkhy marked this pull request as draft January 27, 2024 14:30
@kathleenkhy kathleenkhy force-pushed the feat/payments-thank-you-preview branch from 8837c68 to afab14d Compare January 27, 2024 14:39
@kathleenkhy kathleenkhy force-pushed the feat/payments-thank-you-preview branch from 02e30d7 to 867fd33 Compare January 28, 2024 18:06
@kathleenkhy kathleenkhy marked this pull request as ready for review January 31, 2024 06:43
@kathleenkhy kathleenkhy force-pushed the feat/payments-thank-you-preview branch 2 times, most recently from 85ce575 to a41258f Compare February 19, 2024 08:31
# Conflicts:
#	frontend/src/features/public-form/components/FormPaymentPage/FormPaymentPage.tsx
#	frontend/src/features/public-form/components/FormPaymentPage/stripe/StripePaymentElement.tsx
#	shared/types/form/product.ts
@kathleenkhy kathleenkhy force-pushed the feat/payments-thank-you-preview branch 2 times, most recently from 0cda517 to 589c53e Compare February 19, 2024 16:25
@kathleenkhy kathleenkhy force-pushed the feat/payments-thank-you-preview branch from 589c53e to 69b9a8f Compare February 19, 2024 16:42
@kathleenkhy kathleenkhy force-pushed the feat/payments-thank-you-preview branch from a9e54b7 to 906fbed Compare February 20, 2024 09:15
@kathleenkhy kathleenkhy force-pushed the feat/payments-thank-you-preview branch from 906fbed to ef3e717 Compare February 20, 2024 10:35
@kathleenkhy kathleenkhy merged commit 9295f74 into develop Feb 20, 2024
23 of 25 checks passed
@kathleenkhy kathleenkhy deleted the feat/payments-thank-you-preview branch February 20, 2024 10:57
@justynoh justynoh mentioned this pull request Feb 21, 2024
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants