-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: payments thank you page preview and edit mode #6969
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kathleenkhy
changed the title
Feat/payments thank you preview
feat:payments thank you preview
Dec 20, 2023
kathleenkhy
changed the title
feat:payments thank you preview
feat: payments thank you page preview and edit mode
Dec 20, 2023
kathleenkhy
force-pushed
the
feat/payments-thank-you-preview
branch
3 times, most recently
from
January 23, 2024 08:33
7e58ff5
to
00946a4
Compare
kathleenkhy
force-pushed
the
feat/payments-thank-you-preview
branch
from
January 23, 2024 08:38
00946a4
to
8e6cc42
Compare
kathleenkhy
force-pushed
the
feat/payments-thank-you-preview
branch
from
January 27, 2024 14:39
8837c68
to
afab14d
Compare
kathleenkhy
force-pushed
the
feat/payments-thank-you-preview
branch
from
January 28, 2024 18:06
02e30d7
to
867fd33
Compare
KenLSM
reviewed
Jan 31, 2024
frontend/src/features/admin-form/create/end-page/EndPageContent.tsx
Outdated
Show resolved
Hide resolved
6 tasks
kathleenkhy
force-pushed
the
feat/payments-thank-you-preview
branch
2 times, most recently
from
February 19, 2024 08:31
85ce575
to
a41258f
Compare
# Conflicts: # frontend/src/features/public-form/components/FormPaymentPage/FormPaymentPage.tsx # frontend/src/features/public-form/components/FormPaymentPage/stripe/StripePaymentElement.tsx # shared/types/form/product.ts
KenLSM
approved these changes
Feb 19, 2024
kathleenkhy
force-pushed
the
feat/payments-thank-you-preview
branch
2 times, most recently
from
February 19, 2024 16:25
0cda517
to
589c53e
Compare
kathleenkhy
force-pushed
the
feat/payments-thank-you-preview
branch
from
February 19, 2024 16:42
589c53e
to
69b9a8f
Compare
kathleenkhy
force-pushed
the
feat/payments-thank-you-preview
branch
from
February 20, 2024 09:15
a9e54b7
to
906fbed
Compare
kathleenkhy
force-pushed
the
feat/payments-thank-you-preview
branch
from
February 20, 2024 10:35
906fbed
to
ef3e717
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, the thank you page for payment forms are not editable and users will only be able to use the default title and paragraph text provided for the thank you page. The preview of the thank you page should also reflect the new designs for the thank you page for payment forms.
Closes FRM-1560, FRM-1597, FRM-1572
Solution
To allow the thank you page for payment forms to be editable
Breaking Changes
Before & After Screenshots
BEFORE:
AFTER:
Tests
Payments Form
Ensure that design is updated in Edit mode
Button text
andButton redirect
link should be disabledSave proof of payment
button, the page should be refreshed/ reloadedEnsure that design is updated in Preview mode
Save proof of payment
button, the page should be refreshed/ reloadedThank you page happy flow with actual form
Save proof of payment
button, the invoice PDF should be downloadedNon-Payments Form
In Edit Mode
Save proof of payment
button, the page should be refreshed/ reloadedIn Preview Mode
Save proof of payment
button, the page should be refreshed/ reloadedIn Actual Form
share
button to launch the formSubmit another response
button, the form should be refreshed to show a new form