-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: encryption boundary shift in preview mode #7071
Conversation
0ffeec1
to
cd26e64
Compare
|
cd26e64
to
f2105ff
Compare
…attachments in preview
f2105ff
to
2d30df0
Compare
frontend/src/features/admin-form/common/components/PreviewFormBanner/PreviewFormBanner.tsx
Show resolved
Hide resolved
frontend/src/features/admin-form/common/AdminViewFormService.ts
Outdated
Show resolved
Hide resolved
e469ba9
to
33d6efd
Compare
33d6efd
to
b5be5da
Compare
src/app/routes/api/v3/admin/forms/__tests__/admin-forms.preview.routes.spec.ts
Outdated
Show resolved
Hide resolved
src/app/routes/api/v3/admin/forms/__tests__/admin-forms.preview.routes.spec.ts
Outdated
Show resolved
Hide resolved
src/app/routes/api/v3/admin/forms/__tests__/admin-forms.preview.routes.spec.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for the deleted tests, email previews should not be affected - could you please reinstate them and check if they are failing?
otherwise lgtm!
024d7d1
to
b26d033
Compare
thanks for making the edits @kathleenkhy, lgtm! and happy cny too 🧧🧧🧧 please write some manual tests for the PR description before merging in so we can test during release 😊 |
b26d033
to
09234a2
Compare
Problem
Adding encryption boundary shift for storage mode form submissions previews.
Closes FRM-1506
Solution
added encryption shift to preview mode - also reducing the complexity of implementing encryption within preview mode by no longer saving any answers or attachments uploaded in preview mode (formData will be saved as an empty object {}).
This decision was made because:
Breaking Changes
Manual Tests