Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: encryption boundary shift in preview mode #7071

Merged
merged 6 commits into from
Feb 13, 2024

Conversation

kathleenkhy
Copy link
Contributor

@kathleenkhy kathleenkhy commented Feb 8, 2024

Problem

Adding encryption boundary shift for storage mode form submissions previews.

Closes FRM-1506

Solution

added encryption shift to preview mode - also reducing the complexity of implementing encryption within preview mode by no longer saving any answers or attachments uploaded in preview mode (formData will be saved as an empty object {}).

This decision was made because:

  • use of preview mode, let alone uploading attachment functionality or sending of answers to users' emails (via email confirmation if selected as a field) within preview mode is low
  • main value/ usage of preview mode is primarily used for testing what the look and feel of the form would look like, rather than viewing the answers/ attachments saved in the preview mode after submitting a form

Breaking Changes

  • [ X] No - this PR is backwards compatible

Manual Tests

  1. To check that no data (i.e. an empty object {}) is sent to the Backend
  • Enter Preview mode in Admin view (by clicking the eye button on the top right hand corner)
  • Enter your Network tab
  • Fill in form fields in the preview mode
  • Upon clicking submit, check in the Network tab that the storage call has an empty object {} under Payload
  1. To check that the preview banner warns the user that no answers or attachments uploaded will be saved
  • For non-payment forms, the banner should show:

You will not be able to view submitted answers or attachments in Form Preview mode. Open your form to test a form submission.

  • For payment forms, the banner should show:

You will not be able to make a test payment, or view submitted answers or attachments in Form Preview mode. Open your form to make a test payment or form submission.

Copy link

linear bot commented Feb 8, 2024

@kathleenkhy kathleenkhy changed the title Feat/encryption boundary shift preview feat: encryption boundary shift preview Feb 8, 2024
@kathleenkhy kathleenkhy force-pushed the feat/encryption-boundary-shift-preview branch from 0ffeec1 to cd26e64 Compare February 8, 2024 07:57
Copy link

mergify bot commented Feb 8, 2024

⚠️ The sha of the head commit of this PR conflicts with #6969. Mergify cannot evaluate rules on this PR. ⚠️

@kathleenkhy kathleenkhy force-pushed the feat/encryption-boundary-shift-preview branch from cd26e64 to f2105ff Compare February 8, 2024 08:18
@kathleenkhy kathleenkhy force-pushed the feat/encryption-boundary-shift-preview branch from f2105ff to 2d30df0 Compare February 8, 2024 08:19
@kathleenkhy kathleenkhy changed the title feat: encryption boundary shift preview feat: encryption boundary shift in preview mode Feb 8, 2024
@kathleenkhy kathleenkhy force-pushed the feat/encryption-boundary-shift-preview branch 2 times, most recently from e469ba9 to 33d6efd Compare February 9, 2024 01:49
@kathleenkhy kathleenkhy force-pushed the feat/encryption-boundary-shift-preview branch from 33d6efd to b5be5da Compare February 9, 2024 09:16
@kathleenkhy kathleenkhy marked this pull request as ready for review February 9, 2024 09:46
Copy link
Contributor

@tshuli tshuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the deleted tests, email previews should not be affected - could you please reinstate them and check if they are failing?

otherwise lgtm!

@kathleenkhy kathleenkhy force-pushed the feat/encryption-boundary-shift-preview branch from 024d7d1 to b26d033 Compare February 10, 2024 08:09
@tshuli
Copy link
Contributor

tshuli commented Feb 10, 2024

thanks for making the edits @kathleenkhy, lgtm! and happy cny too 🧧🧧🧧

please write some manual tests for the PR description before merging in so we can test during release 😊

@kathleenkhy kathleenkhy force-pushed the feat/encryption-boundary-shift-preview branch from b26d033 to 09234a2 Compare February 13, 2024 03:18
@kathleenkhy kathleenkhy merged commit 9798424 into develop Feb 13, 2024
22 of 24 checks passed
@kathleenkhy kathleenkhy deleted the feat/encryption-boundary-shift-preview branch February 13, 2024 06:04
@tshuli tshuli mentioned this pull request Feb 14, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants