Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add polyfill for Object.FromEntries #6996

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Conversation

wanlingt
Copy link
Contributor

@wanlingt wanlingt commented Jan 4, 2024

Problem

Object.FromEntries is incompatible with older browsers. This results in an error being thrown when the public form page is loaded.

Closes FRM-1612

Solution

Add a polyfill from the package polyfill-object.fromentries

Breaking Changes

  • No - this PR is backwards compatible

Tests

Regression

  • Go to a public form page. You should be able to load the page and submit the form successfully.

MRF

  • As a form admin, go to an MRF form that has a workflow
  • Submit the form once.
  • Open the form as the second respondent, using the link sent in the email.
  • Submit the form. The response should be submitted successfully.

Deploy Notes

New dependencies:

  • polyfill-object.fromentries : Provides polyfill for Object.fromEntries()

Copy link

linear bot commented Jan 4, 2024

@wanlingt wanlingt marked this pull request as draft January 4, 2024 07:15
@wanlingt wanlingt closed this Jan 4, 2024
@wanlingt wanlingt reopened this Jan 4, 2024
@wanlingt wanlingt marked this pull request as ready for review January 4, 2024 07:45
Copy link
Contributor

@justynoh justynoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@justynoh justynoh merged commit 41c40e5 into develop Jan 4, 2024
33 checks passed
@justynoh justynoh deleted the fix/object-fromentries branch January 4, 2024 09:03
@justynoh justynoh mentioned this pull request Jan 8, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants