Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Not Applicable to MyInfo occupations list #7032

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

wanlingt
Copy link
Contributor

@wanlingt wanlingt commented Jan 22, 2024

Problem

Certain Pass Type holders have blank as their occupation, however blank values are not allowed to be submitted for MyInfo fields.

Additionally, change the contact information for the e-service ID

Works towards FRM-1433
Close FRSD-18

Solution

Allow respondents to select Not Applicable from the Occupations dropdown.

Breaking Changes

  • No - this PR is backwards compatible

Before & After Screenshots

BEFORE:
image
AFTER:
image

Tests

Singpass

  • Create a Singpass MyInfo form with Occupation as one of the fields
  • Fill in the form as a respondent, select Not Applicable for the occupation field
  • You should be able to submit the form successfully, the form response should also reflect Not Applicable

SGID

  • Repeat the same test as above

Copy link

linear bot commented Jan 22, 2024

@wanlingt wanlingt marked this pull request as ready for review February 2, 2024 06:02
@wanlingt wanlingt merged commit 0a469dc into develop Feb 5, 2024
53 of 55 checks passed
@wanlingt wanlingt deleted the fix/myinfo-occupation branch February 5, 2024 00:54
@wanlingt wanlingt mentioned this pull request Feb 5, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants