Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(virus-scanner): allow endpoint to be specified #7114

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

LoneRifle
Copy link
Collaborator

@LoneRifle LoneRifle commented Feb 29, 2024

Problem

For environments that are neither AWS nor local dev, the virus scanner lambda might be hosted elsewhere, eg, on a host running an emulated environment.

Solution

Grant the flexibility to specify the endpoint address to reach the virus scanner, and thus the discretion to use AWS or some other environment.

Tests

Regression on non-local development env

Virus scanner rejects test virus file

  • Create a form with attachments
  • Submit a test virus file
  • Observe that submission fails

Virus scanner passes virus-safe file

  • Create a form with attachments
  • Submit a plain text file
  • Observe that submission passes

For environments that are neither AWS nor local dev, the virus scanner
lambda might be hosted elsewhere, eg, on a host running an emulated
environment. Grant the flexibility to specify the endpoint address to
reach the virus scanner, and thus the discretion to use AWS or some
other environment.
@LoneRifle LoneRifle force-pushed the feat/virus-scanner/override-endpoint branch from e23f0a4 to 7d575e5 Compare February 29, 2024 05:51
Copy link
Contributor

@KenLSM KenLSM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Added some test cases to go along with it.

@LoneRifle
Copy link
Collaborator Author

Confirming no regression:
Screenshot 2024-03-01 at 10 19 59 AM

@LoneRifle LoneRifle merged commit e0d6ac4 into develop Mar 1, 2024
37 checks passed
@LoneRifle LoneRifle deleted the feat/virus-scanner/override-endpoint branch March 1, 2024 02:21
@KenLSM KenLSM mentioned this pull request Mar 4, 2024
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants