feat(virus-scanner): allow endpoint to be specified #7114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For environments that are neither AWS nor local dev, the virus scanner lambda might be hosted elsewhere, eg, on a host running an emulated environment. Grant the flexibility to specify the endpoint address to reach the virus scanner, and thus the discretion to use AWS or some other environment.
LoneRifle
force-pushed
the
feat/virus-scanner/override-endpoint
branch
from
e23f0a4
to
7d575e5
Compare
KenLSM
approved these changes
Feb 29, 2024
|
Confirming no regression: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
For environments that are neither AWS nor local dev, the virus scanner lambda might be hosted elsewhere, eg, on a host running an emulated environment.
Solution
Grant the flexibility to specify the endpoint address to reach the virus scanner, and thus the discretion to use AWS or some other environment.
Tests
Regression on non-local development env
Virus scanner rejects test virus file
Virus scanner passes virus-safe file