Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add logs for virus scanning duration #7129

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

kathleenkhy
Copy link
Contributor

@kathleenkhy kathleenkhy commented Mar 7, 2024

Problem

Currently we do not keep track of how long it will take for files to be downloaded from S3 - this arose from an alarm due to a spike in time taken for scanning and downloading clean attachments

Solution

Added logs in src/app/modules/submission/submission.service.ts to track the start and end of the download from S3

Breaking Changes

  • No - this PR is backwards compatible

Manual tests

  • Create a form
  • Complete a submission of the form
  • In datadog, search for "Successfully downloaded file from S3"
  • Copy the Clean File Key
  • Search for the clean file key in datadog or cloudwatch and check that there will be 2 logs with the messages of "File download from S3 has started" and "Successfully downloaded file from S3".

Datadog:
image

Cloudwatch:
image

Searching by clean file ID of form submitted:
image

Copy link
Contributor

@KenLSM KenLSM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kathleenkhy kathleenkhy marked this pull request as ready for review March 7, 2024 11:01
@kathleenkhy kathleenkhy merged commit da0d5b7 into develop Mar 8, 2024
38 checks passed
@kathleenkhy kathleenkhy deleted the chore/virus-scanning-duration branch March 8, 2024 07:12
@KenLSM KenLSM mentioned this pull request Mar 19, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants