Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: release v6.117.0 #7266

Merged
merged 22 commits into from
Apr 24, 2024
Merged

build: release v6.117.0 #7266

merged 22 commits into from
Apr 24, 2024

Conversation

KenLSM
Copy link
Contributor

@KenLSM KenLSM commented Apr 22, 2024 •
edited
Loading

New

  • build: merge release v6.116.0 to develop #7263
  • feat(btn): sms removal and announcment #7257
  • chore: update chromium to latest published version #7258
  • chore(dockerfile): bump chromium version to work with alpine-3.19 #7255
  • chore: refactor to move endpage block to generic folder #7248
  • chore: bump version to v6.117.0 d7650f0

Dependencies

  • fix(deps): bump zod from 3.22.4 to 3.22.5 in /shared #7261
  • chore(deps): bump tar from 6.1.11 to 6.2.1 in /serverless/virus-scanner #7253
  • fix(deps): bump tar from 6.2.0 to 6.2.1 #7254

Dev-Dependencies

Tests

feat(btn): sms removal and announcment #7257

Regression

Admins can update twilio credentials

  • Create a new storage form
  • Go to Form Twilio Settings page
  • Enter ACC, SKK, SKK, MGG for the respective fields
  • Ensure that clicking on save credentials isn't blocked

Admins can update OTP fields

  • Ensure that clicking on "Remove and re-enter credentials" isn't blocked

Respondent OTP verification still works

  • Add Mobile field
  • Enable OTP verification
  • Open up the admin form
  • Ensure that verify sends an SMS to you

New feature test

  • Update on SSM SMS_VERIFICATION_LIMIT to 10
  • Send 10 SMS (or until your account rakes up 10 sms sends)
  • Ensure that the 11th SMS is still received by respondent
  • Ensure that admin can still toggle on and off OTP verification field

chore: refactor to move endpage block to generic folder #7248

@KenLSM

  • Create a non-payment form
  • Proceed to the Thank You page tab that it is working as intended
  • Check Preview that the Thank you page is rendered properly
  • Open the form and make a submission - check that the Thank You page is rendered properly
  • Create a payment form
  • Proceed to the Thank You page tab that it is working as intended
  • Check Preview that the Thank you page is rendered properly
  • Open the form and make a submission - check that the Thank You page is rendered properly

MRF Form test

  • Create an MRF form
  • Create 2 workflows
  • Submit the 1st workflow - the Submit another response button should be present
  • Submit the 2nd workflow - the Submit another response button should not be present

kathleenkhy and others added 12 commits April 8, 2024 16:07
@kathleenkhy
chore: refactor to move endpage block to generic folder (#7248)
547d6ce 
* chore: refactor to move endpage block to generic folder

* chore: add thank you and payment ty svgr images to generic folder
@dependabot
fix(deps): bump tar from 6.2.0 to 6.2.1 (#7254)
4f09e89 
Bumps [tar](https://github.com/isaacs/node-tar) from 6.2.0 to 6.2.1.
- [Release notes](https://github.com/isaacs/node-tar/releases)
- [Changelog](https://github.com/isaacs/node-tar/blob/main/CHANGELOG.md)
- [Commits](isaacs/node-tar@v6.2.0...v6.2.1)

---
updated-dependencies:
- dependency-name: tar
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump tar from 6.1.11 to 6.2.1 in /serverless/virus-scann…
0212773 
…er (#7253)

Bumps [tar](https://github.com/isaacs/node-tar) from 6.1.11 to 6.2.1.
- [Release notes](https://github.com/isaacs/node-tar/releases)
- [Changelog](https://github.com/isaacs/node-tar/blob/main/CHANGELOG.md)
- [Commits](isaacs/node-tar@v6.1.11...v6.2.1)

---
updated-dependencies:
- dependency-name: tar
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@LoneRifle
chore(dockerfile): bump chromium version to work with alpine-3.19 (#7255
c1ca224 
)
@KenLSM
chore: update chromium to latest published version (#7258)
6542a0d
@dependabot
fix(deps): bump zod from 3.22.4 to 3.22.5 in /shared (#7261)
8846b00 
Bumps [zod](https://github.com/colinhacks/zod) from 3.22.4 to 3.22.5.
- [Release notes](https://github.com/colinhacks/zod/releases)
- [Changelog](https://github.com/colinhacks/zod/blob/master/CHANGELOG.md)
- [Commits](https://github.com/colinhacks/zod/commits)

---
updated-dependencies:
- dependency-name: zod
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@KenLSM
feat(btn): sms removal and announcment (#7257)
5a80430 
* fe: remove mention of 10k limit

* fe: remove dialog when turning on otp

* feat: remove toggle block when sms quota has been exceeded

* chore: update copy on twilio settings page

* chore: remove mention of 10k limit on twilio cred removal

* chore: update twilio settings copy
@KenLSM
build: merge release v6.116.0 to develop (#7263)
ded3d98 
chore: bump version to v6.116.0
@dependabot @KenLSM
chore(deps): bump tar from 6.1.11 to 6.2.1 in /serverless/virus-scanner
1b53207 
Bumps [tar](https://github.com/isaacs/node-tar) from 6.1.11 to 6.2.1.
- [Release notes](https://github.com/isaacs/node-tar/releases)
- [Changelog](https://github.com/isaacs/node-tar/blob/main/CHANGELOG.md)
- [Commits](isaacs/node-tar@v6.1.11...v6.2.1)

---
updated-dependencies:
- dependency-name: tar
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@KenLSM
chore: reverting package-lock changes
040b962
@KenLSM
Merge remote-tracking branch 'origin/develop' into chore/release-to-d…
8bc11bf 
…evelop

# Conflicts:
#	serverless/virus-scanner/package-lock.json
@KenLSM
Merge pull request #7269 from opengovsg/chore/release-to-develop
8d6429c 
build: release v6.116.0 to develop
@KenLSM
Copy link
Contributor Author

KenLSM commented Apr 22, 2024

Preparing release early -- to ensure that our release isn't blocked by any funny build issues.

dependabot bot and others added 6 commits April 22, 2024 20:01
@dependabot
fix(deps): bump libphonenumber-js from 1.10.60 to 1.10.61 in /shared (#…
22e1123 
…7272)

Bumps [libphonenumber-js](https://gitlab.com/catamphetamine/libphonenumber-js) from 1.10.60 to 1.10.61.
- [Changelog](https://gitlab.com/catamphetamine/libphonenumber-js/blob/master/CHANGELOG.md)
- [Commits](https://gitlab.com/catamphetamine/libphonenumber-js/compare/v1.10.60...v1.10.61)

---
updated-dependencies:
- dependency-name: libphonenumber-js
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
fix(deps): bump zod from 3.22.5 to 3.23.0 in /shared (#7273)
067b9eb 
Bumps [zod](https://github.com/colinhacks/zod) from 3.22.5 to 3.23.0.
- [Release notes](https://github.com/colinhacks/zod/releases)
- [Changelog](https://github.com/colinhacks/zod/blob/master/CHANGELOG.md)
- [Commits](https://github.com/colinhacks/zod/commits/v3.23.0)

---
updated-dependencies:
- dependency-name: zod
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
fix(deps): bump type-fest from 4.15.0 to 4.16.0 in /shared (#7274)
663f599 
Bumps [type-fest](https://github.com/sindresorhus/type-fest) from 4.15.0 to 4.16.0.
- [Release notes](https://github.com/sindresorhus/type-fest/releases)
- [Commits](sindresorhus/type-fest@v4.15.0...v4.16.0)

---
updated-dependencies:
- dependency-name: type-fest
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@KenLSM
chore: allow pip to install packages globally (#7259)
7364bae
@KenLSM
fix: remove phantom fields (#7276)
c82e0fa
@karrui
feat: update localstack docker image (#7271)
c715df2 
Update `localstack` to latest version (but pinned) so the failing SQS noise in local development console is removed.
kathleenkhy
kathleenkhy approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@kathleenkhy kathleenkhy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

KenLSM and others added 2 commits April 23, 2024 18:00
@KenLSM
fix(btn): remove admin sms toggle check (#7275)
0a03210 
* fix: remove admin auto sms disabling

* fix: remove sms quota check on admin otp toggle

* fix: remove test cases related to removed functions

* refactor: remove unneeded call to disableVerifiedFieldsIfRequired
@LoneRifle
feat(i18n): add common strings for translation (#7256)
c450041
justynoh
justynoh approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@justynoh justynoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing complete, lgtm

@justynoh justynoh merged commit 4dc4e5a into release-al2 Apr 24, 2024
38 of 39 checks passed
@justynoh justynoh deleted the release_v6.117.0 branch April 24, 2024 02:10
This was referenced Apr 29, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justynoh justynoh justynoh approved these changes

@kathleenkhy kathleenkhy kathleenkhy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@KenLSM @justynoh @kathleenkhy @LoneRifle @karrui