Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: release v6.118.0 #7293

Merged
merged 12 commits into from
Apr 30, 2024
Merged

build: release v6.118.0 #7293

merged 12 commits into from
Apr 30, 2024

Conversation

KenLSM
Copy link
Contributor

@KenLSM KenLSM commented Apr 29, 2024

New

  • fix: update chromium version #7294
  • feat(btn): phase 2 - add growthbook toggle to control adding twilio creds #7290
  • feat(payments): add min global payment limit override #7291
  • fix: add localhost domain into cors, used by attachment uploads #7280
  • chore: reduce output, check gh login auth status only if not logged in #7282
  • build: merge release v6.117.0 into develop #7284
  • build: release v6.117.0 #7266

Dependencies

  • fix(deps): bump type-fest from 4.16.0 to 4.17.0 in /shared #7287
  • fix(deps): bump zod from 3.23.0 to 3.23.4 in /shared #7283

Dev-Dependencies

Tests

feat(btn): phase 2 - add growthbook toggle to control adding twilio creds #7290

Regression
Feature toggle is off, user should still see will be, and able to add twilio credentials

  • Go to Form Settings > Twilio Credentials page
  • Ensure that the infobox text reads will be disabled from 30 April
  • Ensure that "Save Credentials" button is enabled

New feature test

  • Enable toggle on staging env from growthbook
  • Go to Form Settings > Twilio Credentials page
  • Ensure that the infobox text reads will be disabled from 30 April
  • Ensure that "Save Credentials" button is disabled

Deploy Notes

Ensure that adding-twilio-disabled is added on growthbook (with value: True, but not toggled on production) . It should be disabled before April 30 or enabled if it is after April 30.

  • April 30 is the transition window to enable this on production

New environment variables:

  • adding-twilio-disabled : on growth book to control text message and button.

feat(payments): add min global payment limit override #7291

Approach for testing should be largely regressive in nature, as we do not have an account has this capability enabled from the 3rd party side (stripe).

Regression
Variable Payment - Admin

  • Create a variable payment form
  • Ensure that $0.49 cannot be set as the lower limit
  • Ensure that error message and placeholder should reflect $0.50 as the minimum amount
  • Ensure that $0.50 can be set as the lower limit and saved
  • Ensure that $10 can be set as the upper limit and saved

Variable Payment - Respondent

  • Load the variable payment form
  • Ensure that the lower limit cannot be lower than $0.50
  • Ensure that the lower limit prompt show Enter an amount between S$0.50 and S$10.00.
  • Ensure that a successful payment can be made with $0.50
  • Ensure that the upper limit cannot be higher than $10
  • Ensure that a successful payment can be made with $10

Payment By Products - Admin

  • Create a payment by products form
  • Create a product priced at $10
  • Ensure that product can be saved
  • Create a product priced at $25
  • Ensure that product can be saved

Payment By Products - Respondent

  • Load the payment form
  • Make a payment with both items selected
  • Ensure that a successful payment can be made

New feature test
Variable Payment - Admin

  • Create a variable payment form
  • On the DB set payments_field.global_min_amount_override to be 10 (Int32)
  • Ensure that $0.09 cannot be set as the lower limit
  • Ensure that error message and placeholder should reflect $0.10 as the minimum amount
  • Ensure that $0.10 can be set as the lower limit and saved
  • Ensure that $10 can be set as the upper limit and saved

Variable Payment - Respondent

  • Load the variable payment form
  • Ensure that the lower limit cannot be lower than $0.09
  • Ensure that the lower limit prompt show Enter an amount between S$0.10 and S$10.00.
  • Ensure that a successful payment can be made with $0.10
  • Ensure that the upper limit cannot be higher than $10
  • Ensure that a successful payment can be made with $10

dependabot bot and others added 7 commits April 23, 2024 19:54
Bumps [zod](https://github.com/colinhacks/zod) from 3.23.0 to 3.23.4.
- [Release notes](https://github.com/colinhacks/zod/releases)
- [Changelog](https://github.com/colinhacks/zod/blob/master/CHANGELOG.md)
- [Commits](colinhacks/zod@v3.23.0...v3.23.4)

---
updated-dependencies:
- dependency-name: zod
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
build: merge release v6.117.0 into develop
Bumps [type-fest](https://github.com/sindresorhus/type-fest) from 4.16.0 to 4.17.0.
- [Release notes](https://github.com/sindresorhus/type-fest/releases)
- [Commits](sindresorhus/type-fest@v4.16.0...v4.17.0)

---
updated-dependencies:
- dependency-name: type-fest
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* add flag to allow global min override in form

* allow fe variable fields to pass fe validators

* allow respondent variable payment flow to respect global min override value

* remove check min value check on respondent payment submission

* fix: add missing default variable

* test: add test cases for global limit
…reds (#7290)

feat: add growthbook toggle to control adding twilio creds
@KenLSM
Copy link
Contributor Author

KenLSM commented Apr 29, 2024

Blocked by chromium being updated again on node 3.19. Fixed in #7294

To look into load from the previous LTS repository instead (i.e., v3.18)

update chromium version
Bumps [type-fest](https://github.com/sindresorhus/type-fest) from 4.17.0 to 4.18.0.
- [Release notes](https://github.com/sindresorhus/type-fest/releases)
- [Commits](sindresorhus/type-fest@v4.17.0...v4.18.0)

---
updated-dependencies:
- dependency-name: type-fest
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@KenLSM
Copy link
Contributor Author

KenLSM commented Apr 30, 2024

Ensure that a successful payment can be made with $0.10 not possible to test since Stripe has to whitelist the account_id to remove the $0.5 limits.

@KenLSM KenLSM merged commit 6eeb0b9 into release-al2 Apr 30, 2024
67 checks passed
@KenLSM KenLSM deleted the release_v6.118.0 branch April 30, 2024 05:30
@KenLSM KenLSM restored the release_v6.118.0 branch April 30, 2024 05:30
@KenLSM KenLSM mentioned this pull request Apr 30, 2024
38 tasks
Copy link

mergify bot commented Apr 30, 2024

⚠️ The sha of the head commit of this PR conflicts with #7300. Mergify cannot evaluate rules on this PR. ⚠️

@KenLSM KenLSM deleted the release_v6.118.0 branch April 30, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants