Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(onboarding): touch up onboarding documentation #7348

Merged
merged 2 commits into from
May 27, 2024

Conversation

liangyuanruo
Copy link
Contributor

@liangyuanruo liangyuanruo commented May 27, 2024

Problem

Smoothen the onboarding process for the next batch of engineers onboarding to the project.

Solution

Touch up the README with additional steps that can help to clarify and smoothen the existing process.

Breaking Changes

  • Yes - this PR contains breaking changes
  • No - this PR is backward compatible

Improvements:

  • Updated .nvmrc to use the latest version of Node 18 for local development

Copy link
Contributor

@KenLSM KenLSM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@KenLSM KenLSM changed the title docs/onboarding: touch up onboarding documentation docs(onboarding): touch up onboarding documentation May 27, 2024
@KenLSM
Copy link
Contributor

KenLSM commented May 27, 2024

@liangyuanruo might have to rebase this branch to develop. The fix for the build failure is fixed in 2969cf9 which is already in develop, but before the time you forked it.

@liangyuanruo liangyuanruo merged commit 7a48724 into develop May 27, 2024
17 checks passed
@liangyuanruo liangyuanruo deleted the fix/onboarding branch May 27, 2024 08:54
@KenLSM KenLSM mentioned this pull request May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants