fix: email notifications with wrong submission id #7418
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
For email notifications being sent out by encrypt mode form submissions, the submission ID and the creation date correspond with the form's id and creation date respectively.
Solution
Since the submission id and created time is only generated under
_createSubmission
, we have to move theMailSubmission.sendSubmissionToAdmin
to after these are generated to ensure the created time is consistent with what's shown in the last page.Breaking Changes
Tests