Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: email notifications with wrong submission id #7418

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

g-tejas
Copy link
Contributor

@g-tejas g-tejas commented Jun 20, 2024

Problem

For email notifications being sent out by encrypt mode form submissions, the submission ID and the creation date correspond with the form's id and creation date respectively.

Solution

Since the submission id and created time is only generated under _createSubmission, we have to move the MailSubmission.sendSubmissionToAdmin to after these are generated to ensure the created time is consistent with what's shown in the last page.

Breaking Changes

  • No - this PR is backwards compatible

Tests

  • 1. Create a storage mode form
  • 2. Add admin emails in the "Email notifications" tab
  • 3. Open the form to public
  • 4. Make a submission and note the submission ID and the created timestamp
  • 5. Navigate to email
  • 6. Observe that the email notification contains the ID and timestamp as what's displayed in the last page.

@g-tejas g-tejas requested a review from KenLSM June 20, 2024 07:07
Copy link
Contributor

@KenLSM KenLSM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@g-tejas g-tejas merged commit a953e4d into develop Jun 21, 2024
26 checks passed
@g-tejas g-tejas deleted the fix/wrong-submission-id branch June 21, 2024 02:09
@KenLSM KenLSM mentioned this pull request Jun 24, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants