chore: remove custom logo #979
Conversation
arshadali172
requested review from
liangyuanruo,
karrui and
mantariksh
and removed request for
liangyuanruo and
karrui
| // Check number of forms with customLogo key | ||
| db.getCollection('forms').find({ customLogo: { $exists: true } }).count() | ||
|
|
||
| // Check number of forms with startPage.logo key | ||
| db.getCollection('forms').find({ "startPage.logo.state": { $exists: true } }).count() |
There was a problem hiding this comment.
can we also check how many unarchived forms have only the customLogo key but not startPage.logo.state?
There was a problem hiding this comment.
Based on my queries yesterday:
Total Number of forms: 179888
Forms with startPage.logo.state defined: 139912
Breaks down into:
DEFAULT: 112081
NONE: 8297
CUSTOM: 19534
customLogo may exist for such forms too, but is currently ignored as startPage.logo is defined
Forms with startPage.logo.state undefined: 39977
Breaks down into:
customLogo undefined: 36359 => Currently defaults to agency logo
customLogo defined: 3618 => Currently defaults to customLogo, but once the key is removed, will default to agency logo
There was a problem hiding this comment.
@liangyuanruo there are a sizeable number of forms (i.e. 36359) with neither startPage.logo.state nor customLogo as new forms are created without either key
There was a problem hiding this comment.
to clarify, this is because it's possible to have a form without a logo?
There was a problem hiding this comment.
Old Code
- If
startPage.logo.statepresent, will use state defined therein - If
startPage.logo.stateabsent, will use state defined incustomLogo. Note thatundefinedstate forcustomLogomeans that the default agency logo is to be shown - New forms are created with
startPage.logo.stateabsent andcustomLogoundefinedand hence show the default agency logo
New Code
- If
startPage.logo.statepresent, will use state defined therein - Will ignore
customLogo, althoughcustomLogoshould have been removed fromformdocuments - If
startPage.logo.stateabsent, default agency logo will be shown - New forms are created with
startPage.logo.stateabsent and hence show the default agency logo
There was a problem hiding this comment.
does that make sense @liangyuanruo
how would you suggest I expand it? @liangyuanruo |
Problem
Closes #787
Solution
form.customLogowhich was no longer being usedform.hasheaderwhich was no longer being usedform.logowhich was no longer being usedform.customLogoNotes
form.customLogohas been deleted, such forms with either default to the config instartPage.logoor ifstartPage.logois non-existent (i.e. for all new forms), default to the agency logo.Tests
Deploy Notes