refactor: Add CsvRecord class instead of using adhoc CsvRecord struct #991
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, the decryption worker returns an ad-hoc CsvRecord struct for consumption that is constructed in a piecemeal basis in the business logic.
Solution
We unify the logic to generate the
CsvRecord
struct in a class with the appropriate methods.Note that we cannot post a full-fledged object (i.e. including JS methods on the object) using
postMessage
, so we construct the appropriate fields as properties of the original CsvRecord, so minimal modification tosubmission.client.factory.js
is necessary.Tests
Ensure that CSV and attachment downloads continue to work as expected.