feat/typesafe - Introduce no-await-without-trycatch #996
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Asynchronous calls in code may result in failure, but the code may not handle the failure case. This can lead to a lack of error messages in the UI, or
UnhandledPromiseRejection
errors and 504 Gateway Timeouts on the server.Solution
typesafe/no-await-without-trycatch
This new ESLint rule helps to warn developers of the possibility of the failure of an async call, by providing visual feedback for situations where an ES2017
await
expression is not used within atry-catch
block.As this rule is meant to be used as a hint without being overly intrusive, the linting rules have been set to
warn
for non-test code and disabled for test code entirely.Features:
await
outside of a try-catch blockScreenshots