Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Upgrade vulnerable axios version #78

Merged
merged 3 commits into from
Nov 29, 2021
Merged

Conversation

timotheeg
Copy link
Contributor

Problem

A vulnerability has been reported against axios.

See Snyk report

Solution

Upgrade to latest axios 0.21.4

@timotheeg
Copy link
Contributor Author

timotheeg commented Sep 10, 2021

Hmm, I just did a simple npm install to get the latest axios version, but the package lock has huge change due to its downgrading from lockfile version 2 back to 1.

Is it expected that lockFile was version 2 previously?

Just for reference, I did the upgrade with node 14 / npm 6.14.13

cc @mantariksh @liangyuanruo

@karrui
Copy link
Contributor

karrui commented Nov 29, 2021

ah, it got upgraded in #66 unknowingly

It's about time we upgrade the node version used anyways, I'll take over this PR and rerun npm i with node 16

Copy link
Contributor

@karrui karrui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@karrui karrui merged commit 8da2947 into develop Nov 29, 2021
@karrui karrui deleted the update_deps branch November 29, 2021 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants