Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code coverage & some test cases #49

Merged
merged 4 commits into from
Aug 12, 2021

Conversation

nurwanto
Copy link

@nurwanto nurwanto commented May 2, 2021

List of Changes

  1. Added NYC module for code coverage, you can run code coverage by execute this command: npm run test:coverage
  2. Added whitelist JS file for code coverage on .nycrc
  3. Added some test cases for StashingStream.spec.js and string-functions.spec.js
  4. Fixed the existing testcases due to integration with NYC module (cli.spec.js)
  5. Change default sub-command on npm run check to npm run test:coverage instead of npm run test (package.json)

Copy link
Collaborator

@LoneRifle LoneRifle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for this!

@LoneRifle LoneRifle merged commit 282f1ed into opengovsg:master Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants