Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLU-237: chore: add variable list ui dropdown enhancement #566

Merged
merged 6 commits into from
May 27, 2024

Conversation

m0nggh
Copy link
Contributor

@m0nggh m0nggh commented May 9, 2024

Problem

The current variable list dropdown is still using MUI components and does not follow OGP DS styles.

Solution

  • Migrate to chakra components and follow ogp ds styles.
  • Remove the expand and collapse list functionality because it was redundant since it is already a scroll component
  • TestResult is also updated accordingly

Tests

  • Check that old pipes still can input variables and execute successfully
  • Check that new pipes can input variables and execute successfully
  • Check that no variables appear after an empty webhook submission is made

Screenshots

Before

SuggestionPopper
image

Test Result
image

After

SuggestionPopper

Screen.Recording.2024-05-09.at.10.40.14.AM.mov

Test Result

Screen.Recording.2024-05-09.at.10.51.30.AM.mov

@m0nggh m0nggh requested a review from a team May 9, 2024 02:52
@m0nggh m0nggh changed the title chore: add variable list ui dropdown enhancement PLU-237: chore: add variable list ui dropdown enhancement May 9, 2024
Copy link

linear bot commented May 9, 2024

PLU-237 Dropdown UI Fix

@m0nggh m0nggh force-pushed the chore/improve-dropdown-ux branch from bc62e12 to 5433e42 Compare May 21, 2024 04:36
Copy link
Contributor

@ogp-weeloong ogp-weeloong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM except the VariablesList height - if we leave at 256px, then test step with very few variables look really weird.

@m0nggh m0nggh merged commit b0748d0 into develop-v2 May 27, 2024
9 checks passed
@m0nggh m0nggh deleted the chore/improve-dropdown-ux branch May 27, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants