-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PLU-237: chore: add variable list ui dropdown enhancement #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m0nggh
changed the title
chore: add variable list ui dropdown enhancement
PLU-237: chore: add variable list ui dropdown enhancement
May 9, 2024
ogp-weeloong
reviewed
May 9, 2024
packages/frontend/src/components/RichTextEditor/SuggestionPopper.tsx
Outdated
Show resolved
Hide resolved
m0nggh
force-pushed
the
chore/improve-dropdown-ux
branch
from
May 21, 2024 04:36
bc62e12
to
5433e42
Compare
packages/frontend/src/components/RichTextEditor/SuggestionPopper.tsx
Outdated
Show resolved
Hide resolved
packages/frontend/src/components/RichTextEditor/SuggestionPopper.tsx
Outdated
Show resolved
Hide resolved
packages/frontend/src/components/RichTextEditor/SuggestionPopper.tsx
Outdated
Show resolved
Hide resolved
packages/frontend/src/components/RichTextEditor/SuggestionPopper.tsx
Outdated
Show resolved
Hide resolved
ogp-weeloong
approved these changes
May 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM except the VariablesList height - if we leave at 256px, then test step with very few variables look really weird.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The current variable list dropdown is still using MUI components and does not follow OGP DS styles.
Solution
Tests
Screenshots
Before
SuggestionPopper
Test Result
After
SuggestionPopper
Screen.Recording.2024-05-09.at.10.40.14.AM.mov
Test Result
Screen.Recording.2024-05-09.at.10.51.30.AM.mov