Added Yarn, truffle, ganache-cli installation in dock/DockerFile so t… #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drortirosh
requested changes
Jun 23, 2019
drortirosh
requested changes
Jun 24, 2019
There was a problem hiding this comment.
Thanks.
But for completeness, please also remove the yarn installation from .circleci/config.yml:
I uploaded a new version of the eth-tools docker image using your updated Dockerfile.
so change the version to eth-tools:solc-5.5b, and remove the "npm i yarn"
This way, your new image is actually gets used (and tested) using our circleCI build step.
drortirosh
previously approved these changes
Jun 24, 2019
|
please rebase so it can be merged. |
…hat commands mentioned in README.md should work As requested, removed installation of Ganache and Truffle Removed npm i -g yarn & modified base image to tabookey/eth-tools:solc-5.5b in circleci/config.yml
dev1644
force-pushed
the
Fix#134/DockerFile-missing-yarn-and-truffle
branch
from
6bbab69
to
c3ed84d
Compare
|
I rebased and rolled up all 3 commits into a single commit since all changes were very small. |
drortirosh
approved these changes
Jun 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…hat commands mentioned in README.md should work.
Fixed issue #134.